Repository navigation
Enable JIT\jit64 caninline test on NativeAOT - #130282
Merged
MichalStrehovsky merged 1 commit intoJul 7, 2026
Merged
MichalStrehovsky merged 1 commit into
MichalStrehovsky merged 1 commit into
Conversation
The StackTrace infra-frame skipping issue tracked by dotnet/runtimelab#183 no longer reproduces for this test. Remove the ActiveIssue attribute (and the now-unused TestLibrary using) so the test runs on NativeAOT again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the src/tests/JIT/jit64/opt/inl/caninline.cs xUnit test for NativeAOT by removing a NativeAOT-only skip attribute and the now-unused TestLibrary dependency, allowing the test to execute again across configurations.
Changes:
- Removed
using TestLibrary;since it is no longer needed. - Removed the
[ActiveIssue(... IsNativeAot)]attribute so the test is no longer skipped on NativeAOT.
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Jul 7, 2026
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
Resolves dotnet/runtimelab#183. The StackTrace infra-frame skipping issue tracked by dotnet/runtimelab#183 no longer reproduces for this test. Remove the ActiveIssue attribute (and the now-unused TestLibrary using) so the test runs on NativeAOT again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/runtimelab#183.
The StackTrace infra-frame skipping issue tracked by dotnet/runtimelab#183 no longer reproduces for this test. Remove the ActiveIssue attribute (and the now-unused TestLibrary using) so the test runs on NativeAOT again.