Consolidate crossgen2-composite and r2r into crossgen2-outerloop pipeline#130370
Open
jtschuster wants to merge 2 commits into
Open
Consolidate crossgen2-composite and r2r into crossgen2-outerloop pipeline#130370jtschuster wants to merge 2 commits into
jtschuster wants to merge 2 commits into
Conversation
Fold the composite-mode coverage that was unique to the crossgen2-composite pipeline into the crossgen2-outerloop pipeline, and stop running crossgen2-composite on a daily schedule. - Add linux_arm and windows_x86 to the R2R_Composite job in outerloop. - Add an R2R_Composite_LargeVersionBubble job (linux_x64, windows_x64) to outerloop. - Remove the daily cron schedule from crossgen2-composite; it can still be invoked manually to validate a change. The outerloop pipeline already builds the same Checked runtime and runs composite mode on the shared platforms at Pri1, so the daily crossgen2-composite run was largely duplicated work. Moving the remaining unique configurations into outerloop keeps coverage (now at Pri1) while eliminating the redundant daily run. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jtschuster
had a problem deploying
to
copilot-pat-pool
GitHub Actions
Failure
jtschuster
had a problem deploying
to
copilot-pat-pool
GitHub Actions
Failure
Member
Author
|
/azp run runtime-coreclr crossgen2-outerloop |
|
No pipelines are associated with this pull request. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Member
Author
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates composite-mode crossgen2 coverage into the existing crossgen2-outerloop pipeline and disables the daily scheduled run of the dedicated crossgen2-composite pipeline, keeping composite coverage while reducing duplicated CI work.
Changes:
- Expanded the
R2R_Compositeouterloop job matrix to includelinux_armandwindows_x86. - Added a new
R2R_Composite_LargeVersionBubbleouterloop job (linux_x64, windows_x64) to preserve “large version bubble” composite coverage. - Removed the cron schedule from
crossgen2-composite.ymlso it runs only when manually invoked.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/coreclr/crossgen2-outerloop.yml | Adds missing composite-mode matrices (linux_arm/windows_x86) and introduces a Pri1 large-version-bubble composite job. |
| eng/pipelines/coreclr/crossgen2-composite.yml | Removes the daily YAML schedule so this pipeline is no longer automatically run. |
The standalone crossgen2 r2r pipeline (eng/pipelines/coreclr/r2r.yml) runs the non-composite ReadyToRun coreclr test suite at Pri1 (testGroup: outerloop). The crossgen2-outerloop pipeline already runs an identical non-composite R2R job on the same daily schedule, on a strict superset of platforms (it additionally covers osx_x64). Verified empirically that the Helix work-item sets are identical on the shared platforms (e.g. linux_x64 and windows_x64 each produced the exact same 90/91 work items on the same queues), so r2r.yml provides no unique coverage. Note: the ADO pipeline definition (runtime-coreclr r2r) points at this YAML path and must be removed/disabled by infra as a follow-up, or it will fail once the file is gone. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jtschuster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates duplicated daily crossgen2 / ReadyToRun coverage into the crossgen2-outerloop pipeline:
linux_armandwindows_x86on theR2R_Compositejob, plus a newR2R_Composite_LargeVersionBubblejob (linux_x64,windows_x64). These were the only configurations unique to crossgen2-composite.runtime-coreclr r2rpipeline (eng/pipelines/coreclr/r2r.yml) - it's fully redundant with outerloop's non-compositeR2Rjob.Deleting
r2r.ymlremoves the YAML but not the ADO pipeline definition. The enabledruntime-coreclr r2rdefinition points at this path and will fail once merged unless we disables or removes it. The now-unscheduledcrossgen2-compositedefinition can optionally be retired too.