Suppress DOTNET_GCHeapAffinitizeRanges during crossgen2 execution#130381
Open
jtschuster wants to merge 2 commits into
Open
Suppress DOTNET_GCHeapAffinitizeRanges during crossgen2 execution#130381jtschuster wants to merge 2 commits into
jtschuster wants to merge 2 commits into
Conversation
The GetConfigurationVariables test sets DOTNET_GCHeapAffinitizeRanges=1. crossgen2 embeds Server GC, which parses this affinity config at heap init. On Windows the value must use the group:index format, so the bare "1" is invalid and the runtime aborts before Main (CLR_E_GC_BAD_AFFINITY_CONFIG_FORMAT), crashing crossgen2 with exit -1. Add DOTNET_GCHeapAffinitizeRanges to the crossgen2 environment-variable suppression list (alongside DOTNET_GCName/GCStress/HeapVerify/ReadyToRun) so crossgen2, a build tool, does not inherit the test target process's GC affinity configuration. Fixes dotnet#130289 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jtschuster
added
area-ReadyToRun
and removed
area-crossgen2-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the crossgen2 execution scripts used by src/tests to ensure crossgen2 (a build tool invoked during ReadyToRun test compilation) does not inherit GC-affinity configuration from the test environment.
Changes:
- Add
DOTNET_GCHeapAffinitizeRangesto the list of DOTNET_* variables suppressed during crossgen2 execution in the bash snippet. - Add
DOTNET_GCHeapAffinitizeRangesto the variables cleared undersetlocalfor the Windows batch snippet (scoped to crossgen2/R2RDump invocation).
Open
3 tasks
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JulieLeeMSFT
added
the
Priority:1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetConfigurationVariables test sets DOTNET_GCHeapAffinitizeRanges=1. crossgen2 embeds Server GC, which parses this affinity config at heap init. On Windows the value must use the group:index format, so the bare "1" is invalid and the runtime aborts before Main
(CLR_E_GC_BAD_AFFINITY_CONFIG_FORMAT), crashing crossgen2 with exit -1.
Add DOTNET_GCHeapAffinitizeRanges to the crossgen2 environment-variable suppression list (alongside DOTNET_GCName/GCStress/HeapVerify/ReadyToRun) so crossgen2, a build tool, does not inherit the test target process's GC affinity configuration.
Fixes #130289