Skip to content

More precise range assertions for GT_CNS_INT #130385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamperlin wants to merge 2 commits into
base: main
Choose a base branch
from
+46 −9
Open

More precise range assertions for GT_CNS_INT #130385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2dc8d2
More precise range assertions for GT_CNS_INT
adamperlin Jul 8, 2026
3523185
Fix mis-ordering of non-negative check for constant
adamperlin Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 46 additions & 9 deletions src/coreclr/jit/assertionprop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,21 +289,58 @@ static Range GetRange(Compiler* comp, GenTree* tree, BasicBlock* block, ASSERT_V
}

int64_t constValue = node->AsIntConCommon()->IntegralValue();

if (FitsIn<int32_t>(constValue))
if (constValue < 0)
{
rangeType = TYP_INT;
// We don't try and reason about lower bounds here to simplify the logic.
break;
Comment on lines +292 to +295

@adamperlin adamperlin Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will word this better.

}
else if (FitsIn<uint32_t>(constValue))

// For a non-negative constant, try and find a tighter upper bound
if (constValue <= UINT16_MAX)
{
rangeType = TYP_UINT;
if (constValue <= UINT8_MAX)
Comment thread
adamperlin marked this conversation as resolved.
{
if (constValue <= INT8_MAX)
{
rangeType = TYP_BYTE;
}
else
{
rangeType = TYP_UBYTE;
}
}
else
{
if (constValue <= INT16_MAX)
{
rangeType = TYP_SHORT;
}
else
{
rangeType = TYP_USHORT;
}
}
}

if (constValue >= 0)
else
{
return {SymbolicIntegerValue::Zero, UpperBoundForType(rangeType)};
if (constValue <= UINT32_MAX)
{
if (constValue <= INT32_MAX)
{
rangeType = TYP_INT;
}
else
{
rangeType = TYP_UINT;
}
}
else
{
rangeType = TYP_LONG;
}
}
break;

return {SymbolicIntegerValue::Zero, UpperBoundForType(rangeType)};
}

case GT_QMARK:
Expand Down
Loading