Repository navigation
Disable FullPdbThrower test in ilasm round trip testing - #131238
Merged
Merged
Conversation
ilasm only supports portable pdbs
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FullPdbThrower test project configuration to opt out of ilasm round-trip testing by setting IlasmRoundTripIncompatible, based on the fact that the project can produce Windows “Full” (classic) PDBs.
Changes:
- Add
<IlasmRoundTripIncompatible>true</IlasmRoundTripIncompatible>toFullPdbThrower.csproj. - Update the surrounding comment to include the new compatibility flag.
MichalStrehovsky
approved these changes
Jul 22, 2026
AaronRobinsonMSFT
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ilasm only supports portable pdbs