Skip to content

Fix configuration reload test race #133368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svick merged 1 commit into from
Sep 9, 2026
Merged

Fix configuration reload test race #133368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ public async Task DeletingFilesThatRedefineKeysWithReload(bool optional)
_fileSystem.DeleteFile(_iniFile);

await WaitForChange(
() => config["Key"] == "JsonValue1",
() => config["Key"] == "JsonValue1" && token.HasChanged,
"Notification failed for deleting ini file.");

Assert.Equal("JsonValue1", config["Key"]);
Expand All @@ -850,7 +850,7 @@ await WaitForChange(
_fileSystem.DeleteFile(_jsonFile);

await WaitForChange(
() => config["Key"] == "XmlValue1",
() => config["Key"] == "XmlValue1" && token.HasChanged,
"Notification failed for deleting JSON file.");

Assert.Equal("XmlValue1", config["Key"]);
Expand All @@ -860,7 +860,7 @@ await WaitForChange(
_fileSystem.DeleteFile(_xmlFile);

await WaitForChange(
() => config["Key"] == null,
() => config["Key"] is null && token.HasChanged,
"Notification failed for deleting XML file.");

Assert.Null(config["Key"]);
Expand All @@ -870,7 +870,7 @@ await WaitForChange(
_fileSystem.WriteFile(_jsonFile, @"{""Key"": ""JsonValue1""}");

await WaitForChange(
() => config["Key"] == "JsonValue1",
() => config["Key"] == "JsonValue1" && token.HasChanged,
"Notification failed for re-creating JSON file.");

Assert.Equal("JsonValue1", config["Key"]);
Expand All @@ -891,7 +891,7 @@ await WaitForChange(
_fileSystem.WriteFile(_iniFile, @"Key = IniValue1");

await WaitForChange(
() => config["Key"] == "IniValue1",
() => config["Key"] == "IniValue1" && token.HasChanged,
"Notification failed for re-creating ini file.");

Assert.Equal("IniValue1", config["Key"]);
Expand Down
Loading