Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
This was referenced Sep 22, 2026
Open
vcsjones
marked this pull request as ready for review
September 24, 2026 21:05
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The cryptographic CMS implementation is complex and validation was not run, so final human review is required.
Review effort: Lite
Findings: None
What changed in this PR
Adds managed Composite ML-KEM encryption and explicit private-key decryption support for EnvelopedCms, with CMS test vectors and validation coverage.
Changes:
- Implements Composite ML-KEM encapsulation and decapsulation.
- Adds CMS encoding, algorithm identifiers, and test infrastructure.
- Adds encryption, decryption, interoperability, and validation tests.
| File | Summary |
|---|---|
src/libraries/System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj |
Adds ASN.1 sources and test wiring. |
src/libraries/System.Security.Cryptography.Pkcs/tests/Oids.cs |
Adds required Composite ML-KEM and CMS algorithm OIDs. |
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/MLKemDecryptTests.cs |
Removes obsolete unsupported Composite ML-KEM tests. |
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/CompositeMLKemEncryptTests.cs |
Adds Composite ML-KEM encryption coverage. |
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/CompositeMLKemDecryptTests.cs |
Adds decryption and validation coverage. |
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/CompositeMLKemCmsTestData.cs |
Builds Composite ML-KEM CMS test fixtures. |
src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/EnvelopedCms.Kem.cs |
Routes Composite ML-KEM decryption. |
src/libraries/System.Security.Cryptography.Pkcs/src/Internal/Cryptography/Pal/AnyOS/ManagedPal.Kem.cs |
Implements Composite ML-KEM CMS processing. |
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/CompositeMLKem/CompositeMLKemTestVector.cs |
Exposes Composite ML-KEM certificate test data. |
bartonjs
reviewed
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Composite ML-KEM for EnvelopedCms.
GetCompositeMLKemPrivateKeyis not implemented at all onX509Certificate2right now, so the only "door" that works is for folks that use the "Here is the private key" overload.