Skip to content

Honor stack_limit in NativeAOT PromoteCarefully #134506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 3 commits into from
Sep 24, 2026
Merged

Honor stack_limit in NativeAOT PromoteCarefully #134506

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
252e16e
Honor stack_limit in NativeAOT PromoteCarefully
am11 Sep 23, 2026
9bfa6ed
Sync comment with coreclr
am11 Sep 23, 2026
e3980eb
Merge branch 'main' into patch-61
am11 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/coreclr/nativeaot/Runtime/GcEnum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,14 @@ static void PromoteCarefully(PTR_PTR_Object obj, uint32_t flags, ScanFunc* fnGcE
//
assert(flags & GC_CALL_INTERIOR);

// If the object reference points into the stack, we
// must not promote it, the GC cannot handle these.
if (pSc->thread_under_crawl->IsWithinStackBounds(*obj))
// Note that the base is at a higher address than the limit, since the stack
// grows downwards.
// To check whether the object is in the stack or not, we also need to check the sc->stack_limit.
// The reason is that on Unix, the stack size can be unlimited. In such case, the system can
// shrink the current reserved stack space. That causes the real limit of the stack to move up and
// the range can be reused for other purposes. But the sc->stack_limit is stable during the scan.
// Even on Windows, we care just about the stack above the stack_limit.
if (pSc->thread_under_crawl->IsWithinStackBounds(*obj) && ((uintptr_t)*obj >= pSc->stack_limit))
return;

fnGcEnumRef(obj, pSc, flags);
Expand Down
Loading