Repository navigation
Remove the dead clrinterpreter runtime-test scenario - #134805
Merged
Merged
Conversation
The clrinterpreter scenario set DOTNET_Interpret, DOTNET_InterpreterJITThreshold, DOTNET_InterpreterHWIntrinsicsIsSupportedFalse and DOTNET_InterpreterDoLoopMethods, which belonged to the long-removed legacy CoreCLR interpreter and no longer exist. No pipeline uses the scenario; the current interpreter lanes use interpmode1-3. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
Member
|
For reference, originally introduce by #38650 |
jkotas
approved these changes
Sep 28, 2026
lewing
enabled auto-merge (squash)
September 28, 2026 21:01
steveisok
approved these changes
Sep 28, 2026
Member
Author
|
/ba-g slow Mac is stuck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
clrinterpreterscenario fromsrc/tests/Common/testenvironment.proj: theTestEnvironmententry and the_TestEnvFileLineitems (both the Windowssetand Unixexportvariants) that were conditioned on it.The scenario is dead:
DOTNET_Interpret,DOTNET_InterpreterHWIntrinsicsIsSupportedFalse,DOTNET_InterpreterJITThreshold, andDOTNET_InterpreterDoLoopMethods. None of these exist as runtime config values today;clrconfigvalues.honly definesInterpreter,InterpMode,InterpreterName, andInterpreterPath. They came from the legacy CoreCLR interpreter, which was removed long ago. The only later change to these lines was the mechanicalCOMPlus_→DOTNET_rename (Use DOTNET_ variables in tests #76997).interpmode1–interpmode3, which setDOTNET_InterpMode. The-clrinterpreterbuild flag used inruntime-diagnostics.ymlis a separate thing and this PR doesn't change it.Validation: ran
CreateTestEnvFileforinterpmode1andjitstress1with both Windows and osx targets, before and after the change. The generated env files are byte-identical.Note
This PR description was generated with GitHub Copilot.