Repository navigation
Skip interpreter selection when dynamic compilation is unavailable - #134965
Merged
Merged
Conversation
Guard interpreter-versus-JIT selection and module tracking with FEATURE_DYNAMIC_CODE_COMPILED. Retain invalid InterpMode rejection for interpreter-only builds and preserve JIT-enabled selection behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
jkotas
reviewed
Sep 30, 2026
Keep mode selection and validation within FEATURE_DYNAMIC_CODE_COMPILED, avoiding unnecessary mode checks when JIT fallback is unavailable. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jkotas
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile out selection and module tracking when dynamic compilation is unavailable. I chose to keep a cheap unsigned
InterpModerange check that preserves rejection of values outside 0-3 with the same exception and failure stage, but we can remove this also to further reduce code size.Conditional interpreter selection remains unchanged.
Codegen evidence
Independently resolved, matching browser Release WASM binaries and symbol maps show the three selection-only indirect call sites are gone. The
compileMethodbody decreases from 84,606 to 84,510 bytes, with 194 to 191 indirect call sites. Later compilation metadata queries remain.Note
This change and pull request description were generated with GitHub Copilot.