Repository navigation
JIT: mark GC safe point after stelem.ref call transformation - #134973
Merged
Merged
Conversation
fgMorphCall marked the block as a GC safe point while the stelem.ref call was still a user call, before it was replaced by a plain store (or converted back to a helper call). The stale flag could leave a call-free loop without GC polls. Fixes dotnet#134894 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib no diffs (some methods switched to fully-interruptible mode) |
jakobbotsch
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fgMorphCall marked the block as a GC safe point while the stelem.ref call was still a user call, before it was replaced by a plain store (or converted back to a helper call). The stale flag could leave a call-free loop without GC polls.Fixes #134894
Diffs