Repository navigation
Conversation
Add a shared CMake plist helper for dotnet, createdump, corerun, ilasm, ildasm, and non-cross mono-sgen. Leave apphost templates and AOT tools unchanged. Refs dotnet#134977 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-Infrastructure-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
teo-tsirpanis
added
area-Infrastructure
and removed
area-Infrastructure-coreclr
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
hoyosjs
left a comment
hoyosjs
left a comment
There was a problem hiding this comment.
We will also want to get this to hosts that we use - though the important ones are the dotnet host and then createdump. Something like crossgen could probably benefit from this
| target_link_libraries(corerun PRIVATE minipal) | ||
|
|
||
| if(CLR_CMAKE_TARGET_OSX) | ||
| set_macos_bundle_identifier(corerun com.microsoft.dotnet.corerun) |
There was a problem hiding this comment.
We don't ship this one. We can just let it be honestly
Agreed. When I started extending out the fix to other executables, it got uglier than I wanted it to be. |
There was a problem hiding this comment.
you can leave this one out since we'll be removing mono anyway
| @@ -74,12 +75,16 @@ add_executable_clr(ilasm | |||
| ${ILASM_RESOURCES} | |||
| ) | |||
|
|
|||
| if(CLR_CMAKE_TARGET_OSX) | |||
| set_macos_bundle_identifier(ilasm com.microsoft.dotnet.ilasm) | |||
There was a problem hiding this comment.
We're planning on moving ilasm away from C++. Is this something we need to preserve?
There was a problem hiding this comment.
I think we'll need if shipping a native binary, otherwise we won't need it. I'd remove it for now. However, we might want to keep for servicing.
There was a problem hiding this comment.
I think we should eventually have some check in the VMR that all of our native macOS executables have a stable identifier
This branch has not been deployed
5 participants
Add a shared CMake plist helper for dotnet, createdump, corerun, ilasm, ildasm, and non-cross mono-sgen. Leave apphost templates and AOT tools unchanged.
Refs #134977