Skip to content

[wasm][R2R] Re-enable b51875 and b77707 after #134979 - #135027

Merged
lewing merged 1 commit into
mainfrom
lewing-reenable-b51875-b77707-wasm-r2r
Oct 1, 2026
Merged

lewing merged 1 commit into
mainfrom
lewing-reenable-b51875-b77707-wasm-r2r

Conversation

@lewing

@lewing lewing commented Oct 1, 2026

Copy link
Copy Markdown
Member

These JIT regression tests were quarantined for wasm ReadyToRun in #134960 against #134975 (an exception thrown from a finally was reported as unhandled instead of reaching the caller's catch). #134979 ("JIT: make Wasm frames that call a finally unwindable") fixed that and closed #134975, so this removes the three ActiveIssue attributes:

  • JIT/Regression/CLR-x86-JIT/V1-M12-Beta2/b51875/b51875.cs (runner Regression_8)
  • JIT/Regression/CLR-x86-JIT/V1-M12-Beta2/b51875/Desktop/b51875.cs (runner Regression_PdbOnly_r_2)
  • JIT/Regression/CLR-x86-JIT/V1-M12-Beta2/b77707/b77707.cs (runner Regression_PdbOnly_r_2)

Local validation (macOS arm64, branch includes 9997fdf)

./build.sh -s clr+libs -os browser -c checked -lc Release
src/tests/build.sh checked -arch wasm -os browser -priority1 -p:HostConfiguration=Release \
  -test:JIT/Regression/Regression_8.csproj -test:JIT/Regression/Regression_PdbOnly_r_2.csproj
src/tests/build.sh copynativeonly checked -arch wasm -os browser -priority1 -p:HostConfiguration=Release
src/tests/build.sh generatelayoutonly crossgen2 checked -arch wasm -os browser -priority1 -p:HostConfiguration=Release
# per runner, with CORE_ROOT set and DOTNET_TieredCompilation=0:
RunCrossGen2=1 bash ./<Runner>.sh   # R2R mode
bash ./<Runner>.sh                  # interpreter mode

All builds passed. Results from <Runner>.testResults.xml:

Runner Mode b51875 b77707 Pass / Fail / Skip
Regression_8 R2R (crossgen2) Pass n/a 13 / 0 / 0
Regression_8 Interpreter Pass n/a 13 / 0 / 0
Regression_PdbOnly_r_2 R2R (crossgen2) Pass Pass 122 / 0 / 1
Regression_PdbOnly_r_2 Interpreter Pass Pass 122 / 0 / 1

runtime-coreclr outerloop has no PR trigger, so it has to be started manually with /azp run runtime-coreclr outerloop.

Note

This PR was generated with GitHub Copilot assistance.

Remove the ActiveIssue quarantine for #134975, which was
fixed by #134979.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 1, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@lewing
lewing enabled auto-merge (squash) October 1, 2026 15:20
@lewing lewing added the arch-wasm WebAssembly architecture label Oct 1, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@lewing
lewing merged commit 4fcd02f into main Oct 1, 2026
98 checks passed
@lewing
lewing deleted the lewing-reenable-b51875-b77707-wasm-r2r branch October 1, 2026 17:15
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm][R2R] Exception thrown from a finally reached by leave is reported as unhandled instead of reaching the caller's catch (b51875, b77707)

2 participants