Repository navigation
Conversation
… to different test testing similar things
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing the theory leaves explicit assignment of the Default mode untested.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes a flaky shared-process GC setting test and shifts validation to an isolated LOH compaction test.
Changes:
- Removes the parallel-run-sensitive round-trip theory.
- Adds LOH mode checks and corrects an expected-mode diagnostic.
| File | Description |
|---|---|
lohcompactapi2.cs |
Adds compaction-mode validation. |
GCTests.cs |
Removes the flaky round-trip test. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove test sensitive to parallel test run and move checked invariants to different test testing similar things.
Fix #134997