Repository navigation
Unify Thread.SpinWait/Yield/OptimalMaxSpinWaitsPerSpinIteration between CoreCLR and NativeAOT - #135138
Merged
Conversation
…en CoreCLR and NativeAOT Move the managed implementation into shared Thread.cs and back it with native helpers in src/coreclr/runtime/MiscNativeHelpers.cpp, which is compiled into both runtimes. Delete the CoreCLR ThreadNative_SpinWait/ThreadNative_YieldThread QCalls and the GetOptimalMaxSpinWaitsPerSpinIteration FCALL, and the NativeAOT RhSpinWait/RhYield exports. NativeAOT now reports the measured OptimalMaxSpinWaitsPerSpinIteration instead of a hard-coded 8. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac6fb33d-fc74-41c7-a804-75fbf616b155
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
jkotas
reviewed
Oct 2, 2026
Call Thread.GetOptimalMaxSpinWaitsPerSpinIteration() directly from SpinWait and LowLevelSpinWaiter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac6fb33d-fc74-41c7-a804-75fbf616b155
Member
Author
|
@jkotas does it look good otherwise? |
Member
|
/ba-g test failure is known error #135096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the managed implementation into shared Thread.cs and back it with native helpers in src/coreclr/runtime/MiscNativeHelpers.cpp, which is compiled into both runtimes. Delete the CoreCLR ThreadNative_SpinWait/ThreadNative_YieldThread QCalls and the GetOptimalMaxSpinWaitsPerSpinIteration FCALL, and the NativeAOT RhSpinWait/RhYield exports.
NativeAOT now reports the measured OptimalMaxSpinWaitsPerSpinIteration instead of a hard-coded 8.
Fixes dotnet/corert#4430