Skip to content

[wasi] Remove quarantines for wasihost runtimeconfig properties - #135224

Merged
lewing merged 1 commit into
dotnet:mainfrom
lewing:lewing-wasi-unquarantine-134954
Oct 6, 2026
Merged

lewing merged 1 commit into
dotnet:mainfrom
lewing:lewing-wasi-unquarantine-134954

Conversation

@lewing

@lewing lewing commented Oct 5, 2026

Copy link
Copy Markdown
Member

#134964 makes wasihost pass the app's runtimeconfig properties to the runtime, which fixes #134954. This removes the 28 WASI ActiveIssue quarantines against #134954 that #134813 added. The re-enabled tests depend on AppContext switches:

  • System.Data.Common and System.Runtime.Serialization.Xml: DataSet XML serialization (DataSetXmlSerializationIsSupported now sees the trimmed switch value)
  • System.Diagnostics.DiagnosticSource switch tests: Activity ID format
  • System.Globalization.Calendars switch tests: Japanese calendar date parsing
  • System.Runtime.InvariantTimezone: IsInvariant
  • System.Text.Encoding: UTF-7 and code page/encoding name tests

Validation

Run locally on macOS arm64 with wasmtime 49.0.1, against a CoreCLR WASI Release product built from the base that #134813 merged on. Commands were ./dotnet.sh build <test.csproj> /t:Test /p:TargetOS=wasi /p:TargetArchitecture=wasm /p:RuntimeFlavor=CoreCLR /p:Configuration=Release, plus /p:TestWasmReadyToRun=true /p:EnableAggressiveTrimming=true for the trimmed composite R2R lane.

Suite Interpreter Trimmed composite R2R
System.Data.Common.Tests 11,661 run, 0 failed 11,281 run, 0 failed
System.Diagnostics.DiagnosticSource.Switches.Tests 4 run, 0 failed 4 run, 0 failed
System.Runtime.Serialization.Xml.Tests 341 run, 0 failed 341 run, 0 failed
System.Globalization.CalendarsWithConfigSwitch.Tests 1 run, 0 failed 1 run, 0 failed
System.Runtime.InvariantTimezone.Tests 36 run, 0 failed 36 run, 0 failed
System.Text.Encoding.Tests 14,612 run, 0 failed 14,564 run, 0 failed

The only DiagnosticSource skip is IdGenerationInternalParent, which requires multithreading.

Note

This PR description was generated with GitHub Copilot.

dotnet#134964 makes wasihost pass the app's runtimeconfig properties to the runtime,
fixing dotnet#134954. Re-enable the WASI tests that depended on AppContext switches:
DataSet XML serialization, DiagnosticSource ID format switches, the Japanese
calendar and invariant time zone switches, and the UTF-7 and encoding tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@lewing lewing added os-wasi Related to WASI variant of arch-wasm area-Infrastructure-libraries labels Oct 5, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@lewing

lewing commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

/azp runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Command 'runtime-coreclr' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@lewing

lewing commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@lewing
lewing merged commit 7ede41e into dotnet:main Oct 6, 2026
165 of 167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure-libraries os-wasi Related to WASI variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasi][coreclr] wasihost does not pass runtimeconfig properties to the runtime

2 participants