Repository navigation
[wasi] Remove quarantines for wasihost runtimeconfig properties - #135224
Merged
Merged
Conversation
dotnet#134964 makes wasihost pass the app's runtimeconfig properties to the runtime, fixing dotnet#134954. Re-enable the WASI tests that depended on AppContext switches: DataSet XML serialization, DiagnosticSource ID format switches, the Japanese calendar and invariant time zone switches, and the UTF-7 and encoding tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Member
Author
|
/azp runtime-coreclr outerloop |
|
Command 'runtime-coreclr' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#134964 makes wasihost pass the app's runtimeconfig properties to the runtime, which fixes #134954. This removes the 28 WASI
ActiveIssuequarantines against #134954 that #134813 added. The re-enabled tests depend on AppContext switches:DataSetXmlSerializationIsSupportednow sees the trimmed switch value)IsInvariantValidation
Run locally on macOS arm64 with wasmtime 49.0.1, against a CoreCLR WASI Release product built from the base that #134813 merged on. Commands were
./dotnet.sh build <test.csproj> /t:Test /p:TargetOS=wasi /p:TargetArchitecture=wasm /p:RuntimeFlavor=CoreCLR /p:Configuration=Release, plus/p:TestWasmReadyToRun=true /p:EnableAggressiveTrimming=truefor the trimmed composite R2R lane.The only DiagnosticSource skip is
IdGenerationInternalParent, which requires multithreading.Note
This PR description was generated with GitHub Copilot.