Repository navigation
Reject null characters in process arguments - #135236
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f5c176bc-b912-4c76-9b72-ff2c26f2bba0
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
jkotas
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject embedded null characters in
ProcessStartInfo.ArgumentsandProcessStartInfo.ArgumentListwhen starting a process.Validation runs in the shared
ProcessStartInfo.ThrowIfInvalidpath, before platform-specific command-line orargvconstruction. It reportsArgumentsor the indexedArgumentList[n]entry as the invalid parameter.As with the environment-variable validation added in #132214 and clarified in #132640, this is hygienic validation rather than a primary security mitigation. Process arguments are trusted inputs under .NET's published security baseline.
Tests
dotnet build /t:test .\src\libraries\System.Diagnostics.Process\tests\System.Diagnostics.Process.Tests.csproj— passed: 692 total, 0 failed, 2 skipped.Note
This pull request description was generated by GitHub Copilot.