Repository navigation
Improve HttpListener NTLM test failure diagnostics - #135322
Merged
Merged
Conversation
Preserve the exact NTLM handshake stage and HTTP status when the extended-protection policy test fails, instead of reporting only UnexpectedFailure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This was referenced Oct 7, 2026
rzikm
approved these changes
Oct 7, 2026
MihaZupan
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NtlmHandshakeResultenum with a result that preserves authentication state, HTTP status, and the failing handshake stageThis is primarily a diagnostic contribution to #135190 and may help narrow or stabilize the intermittent failure. We did not reproduce the original
UnexpectedFailure, so this PR intentionally does not relax the expected behavior. We can watch CI for further occurrences and use the added details if it fails again.Validation
build.cmd clr+libs -rc releasedotnet build /t:test src\libraries\System.Net.HttpListener\tests\System.Net.HttpListener.Tests.csproj: 695 total, 0 failed, 7 skippedSystem.Net.HttpListener.TestsNote
This pull request description was prepared with GitHub Copilot assistance.