Repository navigation
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
Thanks, but I don't think it needs to be fixed in that phase, it should be folded long before it. |
Author
Shouldn't the TODO than not be updated to state that we assume this case not useful instead? The only reason to investigate this was the TODO. |
Corniel
force-pushed
the
jit-fold-same-directions
branch
from
October 11, 2026 22:32
716387b to
8c699a8
Compare
Author
|
@EgorBo Just updated the todo now. As you stated: should not occur. |
Member
|
I don't think that todo makes sense. What I meant is that if it doesn't happen, we should fix it in RBO - it's RBO's responsibility to fold redundant checks |
Member
|
Let's keep it as is then, I'll take a look at RBO when I have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #135421 was created to support folding ranges, I noticed there was a TODO in there for same direction compares. Although you would hope these kind of logic would not be fed to the JIP that often, it might be worth handling.