Repository navigation
Conversation
…enhance test coverage
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This was referenced Oct 13, 2026
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default
IHttpClientFactorylogging currently records failures only forHttpRequestException, leaving other handler exceptions without a corresponding failure event.This change extends both default logging handlers to record non-cancellation exceptions and rethrow them unchanged. The outer handler records failures escaping the pipeline; the inner handler records only failures from the portion it wraps. Existing event IDs, names, categories, levels, and redaction behavior are preserved.
OperationCanceledExceptionand its subclasses remain excluded. HTTP error responses and failures while reading response content after the pipeline returns retain their existing treatment. No public API is added.Testing
Expanded the existing failure-logging test to 26 cases covering synchronous/asynchronous sends, early rejection, primary-handler failures, cancellation, event metadata, and exception identity.
Microsoft.Extensions.Httpsuite passed 210/210 tests on WSL/Linux x64.Resolves #135199