Repository navigation
ILVerify error cleanup - #135798
Merged
Merged
ILVerify error cleanup#135798
Conversation
The existing verifier already covers most of the legacy diagnostics under newer error codes. I found one concrete gap: `unaligned.` currently ignores its alignment operand, so I’m adding that check and a regression test, while removing the obsolete commented-out entries. Closes #37393
github-actions
Bot
added
the
area-Tools-ILVerification
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted validation and regression cases are straightforward; the remaining diagnostic-message feedback is non-blocking.
1 open finding
What changed in this PR
This PR closes an ILVerify validation gap by checking unaligned. operands and removing obsolete diagnostic comments.
Changes:
- Accept only alignment values 1, 2, and 4.
- Add valid-alignment coverage and an invalid-alignment regression case.
- Add the diagnostic code without renumbering existing codes.
Builds and tests were not run.
| File | Description |
|---|---|
| src/coreclr/tools/ILVerification/VerifierError.cs | Removes obsolete comments and adds UnalignedAlignment. |
| src/coreclr/tools/ILVerification/ILImporter.Verify.cs | Validates the alignment operand. |
| src/coreclr/tools/ILVerification.Tests/ILTests/PrefixTests.il | Covers valid values and rejects alignment 3. |
🧠 Review effort: Balanced
This was referenced Oct 15, 2026
Closed
Member
Author
|
/ba-g opened #135843 on the test failure |
jkotas
enabled auto-merge (squash)
October 15, 2026 06:47
Member
|
LGTM. It correctly restricts |
JulieLeeMSFT
approved these changes
Oct 16, 2026
pcshrosbree
added a commit
to pcshrosbree/runtime
that referenced
this pull request
Oct 17, 2026
Resolve the conflict in VerifierError.cs with dotnet#135798, which removed the commented-out native verifier codes from the enum: keep main's enum and put this branch's doc comments back on each of its values. The other files merge without conflicts.
pcshrosbree
added a commit
to pcshrosbree/runtime
that referenced
this pull request
Oct 17, 2026
dotnet#135924 made IsByRefLike(StackValue) return true for ByRef-like types as well as ByRefs, so ArrayByRef, TailByRef and BoxByRef now cover ByRef-like types too; say so in their summaries. Document UnalignedAlignment, which dotnet#135798 added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing verifier already covers most of the legacy diagnostics under newer error codes. I found one concrete gap:
unaligned.currently ignores its alignment operand, so I’m adding that check and a regression test, while removing the obsolete commented-out entries.Closes #37393