Repository navigation
Add CompExactlyDependsOn to some methods so that they are compiled on wasm - #135869
Merged
Merged
Conversation
… wasm A method having multiple `CompExactlyDependsOn` attributes with various instruction sets is compiled only if at least one of these instruction sets is supported (in addition to the requirement of all ISAs to be deterministically supported or unsupported at run time). `CompHasFallback` serves the purpose of still compiling the method even if none of the ISAs is supported. In our case here, all these methods are already used in the context of other methods depending on PackedSimd so we just need to add this missing attribute to enable their compilation. For example, this makes `System.Text.RegularExpressions.Tests.Perf_Regex_Common.ReplaceWords` 100x faster.
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
Contributor
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
lewing
approved these changes
Oct 15, 2026
This was referenced Oct 15, 2026
Closed
Member
Author
|
/ba-g failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A method having multiple
CompExactlyDependsOnattributes with various instruction sets is compiled only if at least one of these instruction sets is supported (in addition to the requirement of all ISAs to be deterministically supported or unsupported at run time).CompHasFallbackserves the purpose of still compiling the method even if none of the ISAs is supported. In our case here, all these methods are already used in the context of other methods depending on PackedSimd so we just need to add this missing attribute to enable their compilation.For example, this makes
System.Text.RegularExpressions.Tests.Perf_Regex_Common.ReplaceWords100x faster.