[pcshrosbree]

Problem: ILVerify reports LdftnCtor and TailStackEmpty with the error name as the message. With the ILVerify CLI built from main (relevant lines; paths shortened):

[IL]: Error [LdftnCtor]: [Probe.dll : P::LdftnCtor()][offset 0x00000000] LdftnCtor
[IL]: Error [TailStackEmpty]: [Probe.dll : P::TailStackNotEmpty()][offset 0x00000004] TailStackEmpty

For errors reported by the IL importer, Verifier looks up the message in Strings.resx by the error's name, and uses the name when the entry is missing or empty (Verifier.cs:394-401). The entry for LdftnCtor is named LdftnConstructor, and TailStackEmpty has no entry.

Fix: rename the entry to LdftnCtor, and add a TailStackEmpty entry with the text of its comment in VerifierError.cs, "Stack not empty after tail call." Renaming the entry rather than the enum member leaves the public VerifierError unchanged, along with the CLI's --ignore-error patterns, which match error names. Nothing else in the repo references LdftnConstructor.

Validation

New test: VerificationResultTests.EveryErrorHasMessage checks that every VerifierError other than None has a non-empty entry in Strings.resx. With the fix reverted, it fails, listing LdftnCtor and TailStackEmpty; every other error already has an entry.

I understand this test may be considered low value for a resource fix, and I have no problem dropping it. I added it because I have seen tools built on PEVerify rely on the message text and break when it changes. The text is not part of the contract, and the test does not check wording; it catches a missing or empty entry, which silently turns a message into the bare error name, as happened here.

ILVerification.Tests, on main at 11ce222, with linux-x64 and SDK 11.0.100-rc.1.26420.103. Each row ran ./dotnet.sh build src/coreclr/tools/ILVerification.Tests/ILVerification.Tests.csproj -c <config>, then ./dotnet.sh test on the same project with --no-build:

Tree	Configuration	Result
main unchanged	Release	484/484
main unchanged	Debug	484/484
this change	Release	485/485
this change	Debug	485/485
new test with the fix reverted	Release	484/485; the new test lists LdftnCtor and TailStackEmpty
this change with the entry named LdftnConstructor again	Release	484/485; the new test lists LdftnCtor
this change without the TailStackEmpty entry	Release	484/485; the new test lists TailStackEmpty

ILVerify CLI, built from this branch, on the same two methods (relevant lines; paths shortened):

[IL]: Error [LdftnCtor]: [Probe.dll : P::LdftnCtor()][offset 0x00000000] ldftn/ldvirtftn not allowed on .ctor.
[IL]: Error [TailStackEmpty]: [Probe.dll : P::TailStackNotEmpty()][offset 0x00000004] Stack not empty after tail call.

Note

This PR was prepared with AI assistance (Anthropic Claude and OpenAI Codex), under my direction. I reviewed it before posting.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib
See info in area-owners.md if you want to be subscribed.

[jkotas]

Thanks

[jkotas]

/ba-g known failures that are being worked on

[pcshrosbree]

Thank you for the review and merge!