Consolidate PE loading and virtual memory into CoreCLR minipal by jkoritzinsky · Pull Request #135902 · dotnet/runtime

jkoritzinsky · 2026-10-15T22:30:51Z

Summary

The Unix PAL contained its own PE loader (parsing and mapping sections) to emulate loading PEs, when we already had a concept of a "manually loaded" PE file in our ConvertedImageLayout type. This PR removes that duplication and moves native memory mapping/allocation/protection behind VMToOSInterface in CoreCLR minipal.

Changes

Remove the PAL PE loader/parser/unmap/advice APIs; LoadedImageLayout and NativeImageLayout are now Windows-only.
Unix PEImage owns a file descriptor and maps sections with a shared non-WASM placeholder-based mapper (LoadImageByMappingParts), keeping file backing and page sharing. WASM uses heap-buffer layouts.
Add minipal mapping, allocation, protection and placeholder APIs plus RAII holders, with Windows and Unix backends.
Move non-Windows callers of ClrVirtualAlloc/Free/Protect/Query (and VirtualAlloc/...) to VMToOSInterface, restrict the ClrVirtual* wrappers to Windows, and remove the Virtual* APIs from the CoreCLR PAL.
Delete the obsolete PAL Virtual* API test suites and adapt unrelated PAL tests.
Add managed AssemblyOnDisk tests for layout ownership and concurrency.

Validation

Linux runtime, DAC and browser builds; composite R2R smoke test; ownership and concurrency tests.
Windows x64/x86 builds with AssemblyOnDisk and composite R2R smokes (validated against the earlier PE-loading commits).
Not validated: Apple platforms, WASI, and Windows against the final PAL Virtual* removal commits.

WASM size

Compared dotnet.native.wasm from merge-base 175bffb899e6 (calculated with git merge-base origin/main HEAD) against PR head 86ef27f0271b.

Format	Merge-base (bytes)	PR head (bytes)	Change
Uncompressed	4,529,863	4,526,685	-3,178 (-0.070%)
Brotli	1,318,610	1,316,464	-2,146 (-0.163%)

Both used clean Release CoreCLR browser-wasm builds with identical settings and Emscripten 6.0.2. Compression used Brotli 1.2.0, quality 11, and lgwin 22.

Both builds succeeded (exit code 0) using:

.\build.cmd -os browser -arch wasm -c Release -subset clr.native+libs.native+host.native

Note

This PR description was generated with AI assistance (GitHub Copilot).

Make OS-loaded PE layouts Windows-only and share native section mapping through placeholder-backed VMToOSInterface APIs. Use POSIX descriptors for Unix and WASM PE files, retaining buffer copies on WASM and native mapping elsewhere. Remove the obsolete Unix PAL PE loader and cover source ownership and concurrent loading. Preserve 64-bit file offsets in 32-bit section mapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Deduplicate PE file-handle access and use a shared invalid-file sentinel. Unify the TryOpenFile default while explicitly locking binder opens. Restore tagged SIZE_T image-part boundaries and derive cleanup extents without storing per-part sizes. Route native copied-image allocation and protection through VMToOSInterface, remove Unix PAL release bookkeeping, and simplify Unix allocation with direct mmap handling. Use aligned heap allocation for WASM copies and document placeholder mapping semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… PAL APIs Migrates all non-Windows-only call sites of ClrVirtualAlloc/VirtualAlloc, ClrVirtualFree/VirtualFree, ClrVirtualProtect/VirtualProtect, and ClrVirtualQuery/VirtualQuery from the CoreCLR PAL to the CoreCLR minipal VMToOSInterface abstraction (src/coreclr/minipal), introducing new minipal APIs (ReserveMemoryWithinRange, CommitReservedMemory, DecommitMemory) as needed. Windows-only call paths and native Windows APIs are left intact. Migrated call sites: - utilcode/executableallocator.cpp (Reserve/Commit/Release/ReserveWithinRange) - utilcode/util.cpp (ClrVirtualAllocWithinRange) - utilcode/hostimpl.cpp and vm/hosting.cpp (ClrVirtualAlloc/Free/Protect wrappers; ClrVirtualQuery is now gated #ifdef HOST_WINDOWS since no non-Windows caller remains) - debug/ee/controller.cpp (breakpoint-patch VirtualProtect call sites) - debug/ee/debugger.cpp (DebuggerHeapExecutableMemoryAllocator) - Loader-heap and stub-heap owners (loaderheap.cpp, explicitcontrolloaderheap.cpp, interleavedloaderheap.cpp, loaderheap_shared.cpp/.h, loaderallocator.cpp/.hpp, dynamicmethod.cpp, virtualcallstub.cpp/.h) now thread an explicit size through Release() instead of relying on PAL-tracked allocation bookkeeping. Removes the four PALAPI-exported functions (VirtualAlloc, VirtualFree, VirtualProtect, VirtualQuery) and their declarations from pal/src/map/virtual.cpp and pal/inc/pal.h, along with now-dead helper functions and the HAVE_VM_ALLOCATE Mach-specific block that were only reachable from those four functions. Internal PAL machinery used by other callers (ExecutableMemoryAllocator, CMI bookkeeping, PAL_VirtualReserveFromExecutableMemoryAllocatorWithinRange, PAL_JitWriteProtect, GetVirtualPageSize) is preserved. Deletes the now-obsolete PAL API-conformance test suites for these four APIs (VirtualAlloc, VirtualFree, VirtualProtect, VirtualQuery test directories) and adapts a handful of unrelated PAL tests that used these APIs only as incidental setup (ProbeMemory, IsBadReadPtr, IsBadWritePtr, PAL_EXCEPT_FILTER, ReadFile, WriteFile) to use mmap/mprotect/malloc instead. Validated via: - Full Debug clr+libs+host build and Checked clr + Release libs build, both 0 errors/warnings. - Full PAL test suite run shows no regressions versus baseline (same 20 pre-existing failures on both). - EventPipe GCEvents test passes. - Smoke test exercising GC, JIT/dynamic-method compilation, and GCStress 0xC (exercising gccover.cpp code-patching) passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ClrVirtualAlloc, ClrVirtualFree, ClrVirtualQuery, and ClrVirtualProtect are now declared and defined only when HOST_WINDOWS is set (src/coreclr/inc/clrhost.h, src/coreclr/utilcode/hostimpl.cpp, src/coreclr/vm/hosting.cpp). All remaining non-Windows callers now call the underlying minipal VMToOSInterface APIs directly instead of going through the EE's ClrVirtual* wrapper layer: - vm/gccover.cpp, vm/peimagelayout.cpp: VMToOSInterface::ProtectMemory (peimagelayout.cpp gains a small Win32ProtectionToMemoryProtection helper for its PAGE_* -> MemoryProtection translation; the existing Apple/arm64 PAL_JitWriteProtect special case is preserved unchanged) - vm/eventing/eventpipe/ep-rt-coreclr.h: AllocateMemory / ReleaseMemoryReservation - vm/frozenobjectheap.cpp: ReserveMemoryWithinRange, CommitReservedMemory, ReleaseMemoryReservation - vm/cachelinealloc.cpp: AllocateMemory / ReleaseMemoryReservation - utilcode/util.cpp, utilcode/executableallocator.cpp: ReserveMemoryWithinRange - debug/daccess/daccess.cpp: AllocateMemory / ReleaseMemoryReservation - md/enc/stgio.cpp: ReserveMemoryWithinRange, CommitReservedMemory, ProtectMemory, DecommitMemory, ReleaseMemoryReservation vm/ceeload.cpp's SetTargetForVTableEntry (only reachable under FEATURE_IJW, a Windows-only feature) and vm/threads.cpp's DebugLogStackRegionMBIs/Thread::DebugLogStackMBIs (only reachable from Windows-only RestoreGuardPage) are now gated accordingly, since their definitions referenced ClrVirtualProtect/ClrVirtualQuery without previously being gated themselves. The Windows-only ForceReloc/Debug_AllowCallout debug logic in ClrVirtualAlloc and the UEF debug-check logic in ClrVirtualProtect are preserved unchanged, just de-nested from the now-removed non-Windows branches. Validated with a full Checked CoreCLR build (0 warnings/errors), a GC/JIT smoke test, the GCEvents EventPipe test, and the full PAL test suite (219 passed, 0 failed, no regressions). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ToOSInterface calls Remove the Windows-specific ClrVirtual* branch at call sites that previously had a parallel #ifdef TARGET_UNIX VMToOSInterface::* / #else ClrVirtual* dual path, now that VMToOSInterface's Windows backend forwards directly to the native Win32 APIs for everything except AllocateMemory (which still goes through ClrVirtualAlloc, preserving the ForceRelocs debug-stress logic for PE image mapping). - ep-rt-coreclr.h, frozenobjectheap.cpp, cachelinealloc.cpp, executableallocator.cpp, util.cpp, daccess.cpp, stgio.cpp: coalesced straightforward alloc/commit/decommit/release dual-path sites. - gccover.cpp: coalesced breakpoint-sprinkling ProtectMemory calls (the discarded oldProtect out-param on Windows made this a pure simplification). - ceemain.cpp InitGSCookie: coalesced the GS cookie protect/restore pair; both platforms now use the already-existing Unix-style approach of restoring directly to ReadOnly without querying for a prior protection value. - peimagelayout.cpp ApplyBaseRelocations: coalesced the three ClrVirtualProtect/VMToOSInterface::ProtectMemory call sites to use the existing Unix-style manual old-protection tracking (SectionCharacteristicsToPageProtection/Win32ProtectionToMemoryProtection) unconditionally, since VMToOSInterface::ProtectMemory has no mechanism to return the true previous protection value. The Apple/ARM64 PAL_JitWriteProtect branch is preserved unchanged. - minipal.h/Windows/mapping.cpp: added a MemoryProtection::WriteCopy value (PAGE_WRITECOPY on Windows, same as ReadWrite on Unix where the PAL never offered true copy-on-write) so Win32ProtectionToMemoryProtection no longer collapses PAGE_WRITECOPY to ReadWrite - which would have made VirtualProtect fail on Windows for relocations applied to a FILE_MAP_COPY-backed R2R image view (relocationMustWriteCopy path). Verified via incremental CoreCLR Checked build (0 warnings/errors) and smoke tests exercising FrozenObjectHeap, GC, GS cookie, EventPipe, and R2R base-relocation application (corerun loading System.Private.CoreLib.dll). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… in peimagelayout.cpp ApplyBaseRelocations tracked protection state as Win32 PAGE_* DWORD constants and translated them to VMToOSInterface::MemoryProtection at each ProtectMemory call site. Since this function no longer calls any Win32 protection API directly, track the protection state as VMToOSInterface::MemoryProtection directly instead: - SectionCharacteristicsToPageProtection -> SectionCharacteristicsToMemoryProtection, returning VMToOSInterface::MemoryProtection directly. - Win32ProtectionToMemoryProtection removed entirely. - dwOldProtection (DWORD, 0 meaning 'none') replaced with an explicit hasOldProtection bool plus a VMToOSInterface::MemoryProtection oldProtection value (0 is not a valid MemoryProtection enumerant on all platforms, so a separate flag is needed instead of a sentinel value). - The exec-region checks (bExecRegion bitwise tests against PAGE_EXECUTE/PAGE_EXECUTE_READ/PAGE_EXECUTE_READWRITE/PAGE_EXECUTE_WRITECOPY) replaced with a small IsExecutableProtection(MemoryProtection) helper. No behavior change; this is purely replacing DWORD-based Win32 protection constants with the native MemoryProtection enum already used everywhere else in this function. Verified via incremental CoreCLR Checked build (0 warnings/errors) and smoke tests (corerun loading System.Private.CoreLib.dll as R2R, GC, EventPipe). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move the near-code reservation allocator and JIT write protection into CoreCLR minipal. Remove obsolete PAL page-size, initialization, and DAC export plumbing. Add a heap-backed WASM ExecutableAllocator implementation and exclude native-only mapping and range helpers from WASM builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-10-15T22:34:17Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-10-16T17:49:06Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

🟡 Changes recommended

Confirmed page-size contract mismatches break large Unix DAC allocations and debugger allocations on larger-page systems.

2 open findings

What changed in this PR

Consolidates CoreCLR PE loading and virtual-memory operations into minipal, removing duplicated Unix PAL functionality.

Changes:

Adds mapping, allocation, protection, and ownership abstractions with platform-specific implementations.
Migrates runtime, debugger, and DAC callers; adds dedicated WASM allocation support.
Removes obsolete PAL tests and adds assembly ownership and concurrency coverage.

Validation here was limited to source inspection; no builds or tests were run.

File	Description
src/tests/Loader/CollectibleAssemblies/AssemblyOnDisk/Program.cs	Adds ownership and concurrent-loading tests.
src/coreclr/vm/virtualcallstub.h	Tracks reservation size.
src/coreclr/vm/virtualcallstub.cpp	Releases reservations with their sizes.
src/coreclr/vm/util.hpp	Removes PAL PE ownership helper.
src/coreclr/vm/threads.cpp	Restricts memory-query diagnostics to Windows.
src/coreclr/vm/peimagelayout.h	Adopts minipal holders and platform-specific layouts.
src/coreclr/vm/peimage.h	Uses platform-native file handles.
src/coreclr/vm/peimage.cpp	Implements Unix file-descriptor ownership.
src/coreclr/vm/loaderallocator.hpp	Stores loader-heap reservation size.
src/coreclr/vm/loaderallocator.cpp	Passes reservation size during cleanup.
src/coreclr/vm/hosting.cpp	Restricts virtual-memory wrappers to Windows.
src/coreclr/vm/gccover.cpp	Migrates code-page protection.
src/coreclr/vm/frozenobjectheap.cpp	Migrates heap reservation and commitment.
src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.h	Migrates EventPipe buffer allocation.
src/coreclr/vm/dynamicmethod.cpp	Supplies code-heap release size.
src/coreclr/vm/corhost.cpp	Excludes allocator statistics on WASM.
src/coreclr/vm/coreassemblyspec.cpp	Locks shared image-file opening.
src/coreclr/vm/ceemain.cpp	Migrates startup allocation and protection.
src/coreclr/vm/ceeload.cpp	Guards mixed-mode vtable protection.
src/coreclr/vm/cachelinealloc.cpp	Migrates cache-line allocation and release.
src/coreclr/utilcode/util.cpp	Delegates Unix range reservations to minipal.
src/coreclr/utilcode/loaderheap.cpp	Tracks reservation extents during cleanup.
src/coreclr/utilcode/loaderheap_shared.h	Adds size-aware reservation holder.
src/coreclr/utilcode/loaderheap_shared.cpp	Implements size-aware release.
src/coreclr/utilcode/interleavedloaderheap.cpp	Updates cleanup and WASM handling.
src/coreclr/utilcode/hostimpl.cpp	Restricts virtual-memory wrappers to Windows.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Supplies reservation sizes to cleanup.
src/coreclr/utilcode/executableallocator.wasm.cpp	Adds heap-backed WASM allocator.
src/coreclr/utilcode/executableallocator.cpp	Migrates executable-memory operations.
src/coreclr/utilcode/CMakeLists.txt	Selects platform-specific allocator source.
src/coreclr/pal/tests/palsuite/paltestlist.txt	Removes obsolete test registrations.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Uses native read-only mapping.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Uses native page protections.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadReadPtr/test1/test.cpp	Uses native memory mappings.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualQuery/test1/VirtualQuery.cpp	Deletes obsolete query test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualProtect/test7/VirtualProtect.cpp	Deletes obsolete protection test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualProtect/test6/VirtualProtect.cpp	Deletes obsolete protection test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualProtect/test4/VirtualProtect.cpp	Deletes obsolete protection test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualProtect/test3/VirtualProtect.cpp	Deletes obsolete protection test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualProtect/test2/VirtualProtect.cpp	Deletes obsolete protection test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualProtect/test1/VirtualProtect.cpp	Deletes obsolete protection test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualFree/test3/VirtualFree.cpp	Deletes obsolete release test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualFree/test2/VirtualFree.cpp	Deletes obsolete release test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualFree/test1/VirtualFree.cpp	Deletes obsolete release test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test9/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test8/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test7/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test6/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test5/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test4/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test3/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test22/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test21/virtualalloc.cpp	Deletes obsolete recommit test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test20/virtualalloc.cpp	Deletes obsolete recommit test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test2/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test19/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test18/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test17/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test16/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test15/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test14/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test13/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test12/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test11/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test10/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/VirtualAlloc/test1/VirtualAlloc.cpp	Deletes obsolete allocation test.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/test1/ProbeMemory.cpp	Uses heap allocation for probing.
src/coreclr/pal/tests/palsuite/filemapping_memmgt/ProbeMemory/ProbeMemory_neg1/ProbeMemory_neg.cpp	Uses inaccessible native mapping.
src/coreclr/pal/tests/palsuite/file_io/WriteFile/test2/WriteFile.cpp	Migrates protected test buffers.
src/coreclr/pal/tests/palsuite/file_io/ReadFile/test2/ReadFile.cpp	Migrates protected test buffers.
src/coreclr/pal/tests/palsuite/exception_handling/PAL_EXCEPT_FILTER/test2/pal_except_filter.cpp	Uses native mappings for fault recovery.
src/coreclr/pal/tests/palsuite/compilableTests.txt	Removes deleted test entries.
src/coreclr/pal/tests/palsuite/CMakeLists.txt	Removes deleted test sources.
src/coreclr/pal/src/thread/thread.cpp	Uses minipal page-size queries.
src/coreclr/pal/src/thread/process.cpp	Removes obsolete virtual-memory include.
src/coreclr/pal/src/thread/context.cpp	Uses minipal page-size queries.
src/coreclr/pal/src/misc/cgroup.cpp	Removes obsolete virtual-memory include.
src/coreclr/pal/src/loader/module.cpp	Removes PAL PE-loading APIs.
src/coreclr/pal/src/init/pal.cpp	Removes PAL virtual-memory initialization.
src/coreclr/pal/src/include/pal/virtual.h	Deletes obsolete virtual-memory header.
src/coreclr/pal/src/include/pal/module.h	Removes PE-loading declarations.
src/coreclr/pal/src/include/pal/map.hpp	Removes PE mapping bookkeeping.
src/coreclr/pal/src/exception/signal.cpp	Uses minipal page-size queries.
src/coreclr/pal/src/exception/seh.cpp	Removes obsolete virtual-memory include.
src/coreclr/pal/src/exception/machexception.cpp	Uses minipal page-size queries.
src/coreclr/pal/src/debug/debug.cpp	Uses minipal page-size queries.
src/coreclr/pal/src/CMakeLists.txt	Removes PAL virtual-memory source.
src/coreclr/pal/inc/pal.h	Removes obsolete PAL APIs and flags.
src/coreclr/pal/inc/pal_error.h	Removes obsolete initialization error.
src/coreclr/minipal/Windows/CMakeLists.txt	Includes new Windows memory sources.
src/coreclr/minipal/Windows/allocation.cpp	Adds Windows allocation wrapper.
src/coreclr/minipal/Unix/memory.cpp	Adds WASM allocation and JIT write protection.
src/coreclr/minipal/Unix/doublemapping.cpp	Uses minipal executable reservations.
src/coreclr/minipal/Unix/CMakeLists.txt	Selects native mapping sources.
src/coreclr/minipal/minipal.h	Defines memory APIs and ownership holders.
src/coreclr/minipal/mapping.cpp	Implements shared ownership holders.
src/coreclr/minipal/CMakeLists.txt	Exposes minipal include directory.
src/coreclr/md/enc/stgio.cpp	Migrates metadata paging operations.
src/coreclr/inc/vptr_list.h	Restricts loader layouts to Windows.
src/coreclr/inc/utilcode.h	Excludes range-allocation declaration on WASM.
src/coreclr/inc/switches.h	Updates allocator ownership comment.
src/coreclr/inc/executableallocator.h	Updates allocator contracts and platform guards.
src/coreclr/inc/clrhost.h	Restricts memory wrappers to Windows.
src/coreclr/dlls/mscoree/exports.cpp	Initializes Unix executable-memory pool.
src/coreclr/dlls/mscordac/mscordac_unixexports.src	Removes obsolete PAL export entries.
src/coreclr/debug/ee/debugger.cpp	Migrates debugger heap allocation.
src/coreclr/debug/ee/controller.cpp	Migrates Unix breakpoint-page protection.
src/coreclr/debug/daccess/daccess.cpp	Migrates DAC block allocation and cleanup.

🧠 Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

janvorli

LGTM, thank you!

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…-pe-layout-mapping

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

am11 · 2026-10-27T23:31:01Z

A few leftovers that lost their last users in this PR:

CLRMapViewOfFile / CLRUnmapViewOfFile / CLRMapViewTraits / CLRMapViewHolder in vm/util.hpp and vm/util.cpp
IsRunningOnMojaveHardenedRuntime() in pal/src/misc/utils.cpp and pal/src/include/pal/utils.h
pal/src/map/common.cpp and common.h (W32toUnixAccessControl has no callers now), plus the entry in pal/src/CMakeLists.txt and #include "common.h" in map.cpp
MMAP_ANON_IGNORES_PROTECTION probe in pal/src/configure.cmake and config.h.in
MEM_RESERVE_EXECUTABLE, MEM_PRIVATE, MEM_MAPPED, MEM_TOP_DOWN, MEM_WRITE_WATCH and MEM_LARGE_PAGES in pal/inc/pal.h (the remaining uses are Windows-only: vm/threads.cpp under !TARGET_UNIX, debug/di/rsthread.cpp under interop debugging and !FEATURE_DBGIPC_TRANSPORT, and gc/windows)
nit: ERROR_BAD_LENGTH / ERROR_INVALID_ACCESS in pal_error.h are only referenced from errorstrings.cpp now

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

janvorli

LGTM, thank you!

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jkoritzinsky and others added 7 commits October 12, 2026 22:51

github-actions Bot added the area-PAL-coreclr only for closed issues label Oct 15, 2026

dotnet-policy-service Bot assigned jkoritzinsky Oct 15, 2026

github-project-automation Bot added this to AppModel Oct 15, 2026

jkoritzinsky added area-VM-coreclr and removed area-PAL-coreclr only for closed issues labels Oct 15, 2026

Merge main into unix-pe-layout-mapping

77b1a9d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jkoritzinsky marked this pull request as ready for review October 16, 2026 17:48

jkoritzinsky requested review from AaronRobinsonMSFT and janvorli October 16, 2026 17:48

jkotas reviewed Oct 16, 2026

View reviewed changes

Comment thread src/coreclr/dlls/mscoree/exports.cpp Resolved

jkotas reviewed Oct 16, 2026

View reviewed changes

Comment thread src/coreclr/inc/clrhost.h Resolved

jkotas reviewed Oct 16, 2026

View reviewed changes

Comment thread src/coreclr/minipal/Windows/mapping.cpp Resolved

jkotas reviewed Oct 16, 2026

View reviewed changes

Comment thread src/coreclr/minipal/Windows/mapping.cpp Resolved

janvorli reviewed Oct 16, 2026

View reviewed changes

AaronRobinsonMSFT reviewed Oct 16, 2026

View reviewed changes

jkotas reviewed Oct 16, 2026

View reviewed changes

Comment thread src/coreclr/debug/ee/controller.cpp Resolved

jkotas requested a balanced review from Copilot October 16, 2026 19:25

Copilot started reviewing on behalf of jkotas October 16, 2026 19:25

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread src/coreclr/debug/ee/debugger.cpp Resolved

Comment thread src/coreclr/debug/daccess/daccess.cpp Resolved

This was referenced Oct 16, 2026

The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing #123572

Closed

Test failure: System.Threading.Tests.MutexTests.NameOptionsApiCompatibilityTest #135888

Closed

jkoritzinsky requested a review from janvorli October 22, 2026 22:08

janvorli reviewed Oct 22, 2026

View reviewed changes

jkoritzinsky and others added 2 commits October 22, 2026 23:41

Address executable memory review feedback

8be5968

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use KernelBase for placeholder API lookup

2ecdfd6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jkotas reviewed Oct 23, 2026

View reviewed changes

Comment thread src/coreclr/minipal/Windows/mapping.cpp Resolved

Use API set for placeholder API lookup

7f878dc

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

build-analysis Bot mentioned this pull request Oct 23, 2026

[ci-scan] Test failure: System.Numerics.Tensors.Tests.TensorTests.TensorValueReductionsPreserveScalarOrder #136367

Closed

janvorli reviewed Oct 26, 2026

View reviewed changes

Address Unix memory mapping feedback

e6a1cfc

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jkoritzinsky requested review from janvorli and jkotas October 26, 2026 21:45

janvorli approved these changes Oct 26, 2026

View reviewed changes

caraioniurie47 mentioned this pull request Oct 26, 2026

ReadyToRun: StaticVirtualMethods and InternalMethodImpl Loader tests fail since #135802 #136494

Closed

jkotas reviewed Oct 27, 2026

View reviewed changes

Comment thread src/coreclr/utilcode/executableallocator.cpp Resolved

jkoritzinsky and others added 3 commits October 27, 2026 18:00

Fix Windows cross-build failures

afa5c31

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Explain Unix executable backing requirement

c34340c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into dev/jkoritzinsky/unix…

dda883e

…-pe-layout-mapping

build-analysis Bot mentioned this pull request Oct 27, 2026

Static Abstract/Virtual method failures on browser-wasm #136534

Closed

Fix Apple mobile instruction cache invalidation

d107cc9

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

build-analysis Bot mentioned this pull request Oct 28, 2026

Test failure: System.Numerics.Tensors.Tests.TensorTests.TensorValueReductionsPreserveScalarOrder — CosineSimilarity NaN comparison on ARM32 #136556

Closed

Remove unused PE mapping and PAL APIs

393c45b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jkoritzinsky requested a review from janvorli October 28, 2026 21:41

janvorli approved these changes Oct 29, 2026

View reviewed changes

Comment thread src/coreclr/minipal/Unix/mapping.cpp Resolved

Use Apple cache invalidation API on macOS too

56ccc31

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

janvorli approved these changes Oct 29, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Oct 30, 2026

Crash: access violation in coreclr!PgoManager::getPgoInstrumentationResults during tier-1 background JIT (Windows x86) #134695

Open

jkoritzinsky merged commit c4ad249 into main Oct 30, 2026
147 of 149 checks passed

jkoritzinsky deleted the dev/jkoritzinsky/unix-pe-layout-mapping branch October 30, 2026 18:11

github-project-automation Bot moved this to Done in AppModel Oct 30, 2026

Conversation

jkoritzinsky commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Validation

WASM size

Uh oh!

dotnet-policy-service Bot commented Oct 15, 2026

Uh oh!

azure-pipelines Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

am11 commented Oct 27, 2026

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jkoritzinsky commented Oct 15, 2026 •

edited

Loading