Repository navigation
JIT: Don't assert when printing open generic method names in disasm - #135946
Merged
Merged
Conversation
JitDisasm asserts in a Checked JIT when a comment refers to an open generic method (e.g. ldtoken of a generic method definition), because its signature has CORINFO_TYPE_UNDEF types. This made jit-diff --pmi fail on FSharp.Core. Print such types as <UNDEF> instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79db3824-0fe6-40d8-b876-b1726372e73f
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
Oct 16, 2026
This was referenced Oct 16, 2026
Closed
Member
Author
|
/ba-g infra issues, merging to fix jit-diffs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a failure jit-diff runs into for FSharp.Core.dll
A Checked JIT asserts while printing the disasm comment for an open generic method (e.g.
ldtokenof a generic method definition), because its signature containsCORINFO_TYPE_UNDEFtypes. This madejit-diff --pmifail on FSharp.Core.eePrintMethodandeeGetMethodFullNamenow tolerateCORINFO_TYPE_UNDEFand print it as<UNDEF>.