Repository navigation
[release/8.0] Fix PKCS#7 and deep XML tests - #136200
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 04244c83-37a1-44a3-9d0c-d6bacfc62a35
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
…le minimizing divergence from main Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a8b87957-4a3e-45b2-b3b8-194c3bba8813
PranavSenthilnathan
approved these changes
Oct 22, 2026
Member
Author
|
Test-only fix, adding servicing-approved label |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136062
Fixes #136061
main PR
No main PR is linked; these are test-only adjustments for
release/8.0.Description
Fix two test failures reported on
release/8.0. Production behavior is unchanged.Customer Impact
No production behavior changes. Without these test fixes, release validation remains subject to an incorrect Unix PKCS#7 expectation and a Windows x86 Checked timeout in deep XML test setup.
Regression
Addresses test failures reported on
release/8.0; no product regression is fixed by this PR.Testing
The unchanged baseline was built and tested before the initial fixes. The Unix PKCS#7 failure reproduced; the original CI XML timeout did not reproduce locally.
After the final 10,000-depth adjustment, the following command passed on Windows x86 with Debug libraries and the Checked CoreCLR testhost: 2 passed, 0 failed, 0 skipped. The root and non-root cases each completed in approximately 5 seconds.
The full inner-loop suite was not rerun after the final depth-only adjustment. Earlier full-suite results and timings applied to the superseded byte-payload setup and are not claimed as validation of this final version.
Risk
Low: changes are limited to tests. The XML change is a single depth-constant reduction relative to the release-branch baseline; 10,000 levels still exceeds the default depth limit of 64. Both tests retain their original exception assertions. The PKCS#7 change aligns expectations with the platform importer without changing production code.
Package authoring signed off?
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Not applicable: only test code changes; no package authoring changes are required.