Skip to content

Fix GC hole caused by adrp and add instructions on arm64 #136412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VSadov merged 2 commits into from
Oct 27, 2026
Merged

Fix GC hole caused by adrp and add instructions on arm64 #136412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625fdf4
Initial plan
Copilot Oct 24, 2026
1a898aa
Fix ARM64 GC liveness after ADRP in long address and constant loads
Copilot Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10753,6 +10753,7 @@ BYTE* emitter::emitOutputLJ(insGroup* ig, BYTE* dst, instrDesc* i)
ins = INS_adrp;
fmt = IF_DI_1E;
dst = emitOutputShortAddress(dst, ins, fmt, relPageAddr, addrReg);
emitGCregDeadUpd(addrReg, dst);

ssize_t imm12 = (ssize_t)dstAddr & 0xFFF; // 12 bits
assert(isValidUimm<12>(imm12));
Expand Down Expand Up @@ -11811,6 +11812,11 @@ size_t emitter::emitOutputInstr(insGroup* ig, instrDesc* id, BYTE** dp)
// Local jmp/load case
assert(id->idIsBound());
dst = emitOutputLJ(ig, dst, id);
if (fmt == IF_LARGEADR)
{
// ADRP overwrites the destination before ADD computes the full address.
emitGCregDeadUpd(id->idReg1(), odst + sizeof(code_t));
}
}
sz = sizeof(instrDescJmp);
break;
Expand Down
Loading