Repository navigation
Fix crossgen2 build break in NewObjectFixupSignature - #136497
Merged
MichalStrehovsky merged 1 commit intoOct 27, 2026
Merged
MichalStrehovsky merged 1 commit into
MichalStrehovsky merged 1 commit into
Conversation
dotnet#132955 changed ObjectNode.ComputeNonRelocationBasedDependencies to take a DependencySink, and dotnet#135802 added NewObjectFixupSignature with the old DependencyList-returning override. The two merged without a textual conflict, so ILCompiler.ReadyToRun no longer compiles. Move the override to the sink-based signature, as NewArrayFixupSignature does. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9444d65-1735-42ee-a4a7-119174358f8d
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
jkotas
approved these changes
Oct 27, 2026
jtschuster
enabled auto-merge (squash)
October 27, 2026 05:49
jtschuster
added a commit
to jtschuster/runtime
that referenced
this pull request
Oct 27, 2026
Same change as dotnet#136497. Revert this commit once that fix is in the branch's base. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9444d65-1735-42ee-a4a7-119174358f8d
agocke
approved these changes
Oct 27, 2026
Member
|
/ba-g fixes a build break in main, the builds already passed, we should get this in |
MichalStrehovsky
disabled auto-merge
October 27, 2026 06:45
This was referenced Oct 27, 2026
jtschuster
added a commit
to jtschuster/runtime
that referenced
this pull request
Oct 27, 2026
The fix landed in main as dotnet#136497. This reverts commit 984183f. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9444d65-1735-42ee-a4a7-119174358f8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#132955 changed
ObjectNode.ComputeNonRelocationBasedDependenciesto take aDependencySinkinstead of returning aDependencyList. #135802 added theNewObjectFixupSignatureoverride using the old signature. The two merged without a textual conflict, soILCompiler.ReadyToRunno longer compiles (CS0115: no suitable method found to override).This moves the override to the sink-based signature, matching
NewArrayFixupSignature.The failure is visible in CI on main, for example the "Build product" step of
runtime-coreclr jitstress(dnceng-public build 1650306).Validated by building
ILCompiler.ReadyToRun.csprojin Debug on top of6d19d4682bdwith this change (0 warnings, 0 errors). It fails to build there without it.Note
This pull request was authored with assistance from GitHub Copilot.