Repository navigation
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This was referenced Oct 30, 2026
System.Net.Http.Functional.Tests now runs SocketsHttpHandler on WASI, so add System.Net.Http.WasiHttpHandler.Functional.Tests, which leaves the UseNativeHttpHandler switch at its WASI default and runs the shared HttpClientHandler tests against WasiHttpHandler. Classes for proxy, decompression and redirect configuration are gated on the HttpClientHandler Supports* capabilities; handler limitations in shared tests are guarded with a new IsWasiHttpHandler property next to IsWinHttpHandler. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Skip the MD5 checks in shared remote-server helpers when MD5 isn't supported (reuse the existing Content-MD5-Skip echo-server path). - Drop the HTTPS local echo server endpoints on WASI, which doesn't trust their development certificate. - Move the SupportsProxy/AutomaticDecompression/RedirectConfiguration probes to the shared test base and use them in the remote-server tests. - Guard WasiHttpHandler gaps (Credentials, redirects, sync stream I/O) with IsWasiHttpHandler, and let the request-content-failure tests tolerate the wasi:http host abandoning the request before it connects. - Remove the guards that the WasiHttpHandler content-failure fix makes unnecessary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
lewing
force-pushed
the
lewing-wasi-http-handler-tests
branch
from
October 30, 2026 15:25
1122b63 to
d8e07d8
Compare
lewing
marked this pull request as ready for review
October 31, 2026 19:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #136234 (and with the handler fixes from #136261),
System.Net.Http.Functional.TestssetsUseNativeHttpHandler=falseon WASI, so it covers SocketsHttpHandler. The switch is process-wide and trimmed, so one assembly can't also test thewasi:httphandler (WasiHttpHandler). This adds a WASI-only test project,System.Net.Http.WasiHttpHandler.Functional.Tests, that leaves the switch at its WASI default (true).Test project
The project adds
WasiHttpHandler_*classes for these shared test bases:It also includes
HttpClientHandler_RemoteServerTest. PostScenarioTest and RemoteServerTest are OuterLoop on WASI.The existing
tests.projglob picks the project up, which adds one Helix work item.Skips
ConditionalClassonSupportsRedirectConfiguration,SupportsAutomaticDecompressionandSupportsProxy. Those probes now live in the sharedHttpClientHandlerTestBase.IsWasiHttpHandler(alongsideIsWinHttpHandler) adds early returns for handler gaps with no public capability flag:wasi:httpbehaviour is also gated:PlatformDetection.IsMD5Supported, using the echo server's existingContent-MD5-Skippath.HttpProtocolTests isn't included: it checks status-line parsing that the
wasi:httphost performs, and Browser excludes it too.Validation
CoreCLR WASI, Release, wasmtime 49.0.1, on main
a932cb67bf6:System.Net.Http.WasiHttpHandler.Functional.TestsSystem.Net.Http.Functional.Tests(shared test changes)Outerloop was validated before the rebase onto current main: 311 of 325 tests passed, with 0 failures, with every class except the two
SupportsProxy-gated proxy classes.Running the full outerloop scope still runs those proxy classes. WasmTestRunner lets
-trait category=OuterLoopoverride-notrait category=failing, soConditionalClass-gated classes run anyway. That's a separate runner issue affecting all WASI/browser projects. The WASI outerloop CI leg currently runs innerloop scope only.Note
This PR description and the changes were generated with GitHub Copilot.