Repository navigation
Conversation
Mark the no-callback fast path complete so disposing the cancellation source closes its wait handle. Cover absent and unregistered callbacks and handle lifetime during asynchronous cancellation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
MihaZupan
marked this pull request as ready for review
October 31, 2026 11:14
This was referenced Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CancelAsync()leaves the source in the notifying state when its no-callback fast path returns. A subsequentDispose()therefore skips closing an existing wait handle because it treats cancellation as still in progress.Mark cancellation complete on that fast path, using the existing volatile state field. This preserves the guard for concurrent cancellation and the immediate return of subsequent cancellation requests.
Regression coverage includes absent and unregistered callbacks, wait handles created before or after cancellation, and handle lifetime with an asynchronous callback.
Resolves #136748
Note
This pull request was prepared with GitHub Copilot.