Repository navigation
Avoid temporary string in CBOR timestamp formatting - #136803
Merged
Merged
Conversation
Format RFC 3339 timestamps into bounded stack storage on modern .NET while retaining legacy target behavior. Extend focused timestamp edge and culture coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-formats-cbor, @bartonjs, @vcsjones |
vcsjones
previously approved these changes
Nov 1, 2026
vcsjones
reviewed
Nov 1, 2026
vcsjones
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CborWriter.WriteDateTimeOffsetcurrently allocates a temporary string solely to pass it to the text-string writer. Format into a bounded 33-character stack buffer withTryFormatand pass the written span to the existing writer instead.Keep the invariant RFC 3339 custom format, UTC
Zspelling, fractional trailing-zero trimming, and existing tag/context handling unchanged. netstandard2.0 and .NET Framework retain the originalToStringpath. Extend the existing tests with focused fraction, offset, date-limit, maximum-length, and culture-invariance cases.