Repository navigation
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Nov 2, 2026
am11
force-pushed
the
chore/pal-file-unused
branch
from
November 2, 2026 12:16
3dcd413 to
7b506fc
Compare
3 tasks
jkotas
reviewed
Nov 2, 2026
am11
changed the title
This was referenced Nov 3, 2026
jkotas
reviewed
Nov 3, 2026
jkotas
reviewed
Nov 3, 2026
jkotas
left a comment
jkotas
left a comment
Member
There was a problem hiding this comment.
Could you please submit the SuperPMI changes and the ilasm/ildasm changes in separate PR? I would like to merge them separately first.
- SuperPMI (superpmi, mcs, shim collector): use stdio FILE* instead of the PAL CreateFile/ReadFile/WriteFile/SetFilePointer/GetFileSize and file-mapping APIs; resolve the JIT path with realpath on Unix. - ilasm, ildasm and metainfo: map files with VMToOSInterface, use minimal Unix path handling instead of GetFullPathName/SearchPathW, and drop the unused console handles. Co-authored-by: Cursor <cursoragent@cursor.com>
- Delete pal/src/file (file.cpp, directory.cpp, path.cpp) and pal/src/map with their headers and PAL tests. - Move the remaining Unix callers to stdio/POSIX/minipal: metadata StgIO, the memory-mapped stress log, the debugger/diagnostics transport names and createdump's default dump path. - Reduce PAL object types to threads and fold single-use PAL helpers into their callers. - Remove configure checks left without users and their tryrun cache values. Co-authored-by: Cursor <cursoragent@cursor.com>
am11
force-pushed
the
chore/pal-file-unused
branch
from
November 3, 2026 22:17
06354ba to
effdcd7
Compare
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #136939 (the SuperPMI and ilasm/ildasm changes, first commit here); this PR is the PAL cleanup on top of it.
pal/src/file(file.cpp,directory.cpp,path.cpp) andpal/src/mapwith their headers and PAL tests. This removes the PAL's Win32 file, path and mapping APIs (CreateFile,ReadFile/WriteFile,SetFilePointer,GetFileSize,FlushFileBuffers,GetStdHandle,CreateFileMapping/MapViewOfFile,GetFullPathName,SearchPathW,GetTempPathA,CreatePipe, ...).StgIO:FILE*andVMToOSInterfacemappingsmmapTMPDIRinline (createdump now adds the missing trailing/)HAVE_PROCFS_STATM,ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS,REALPATH_SUPPORTS_NONEXISTENT_FILES,OPEN64_IS_USED_INSTEAD_OF_OPEN,WRITE_0_BYTES_HANGS_TTY) and their tryrun cache values.