Skip to content

Disable failing WinHttpHandler HTTP/2 test - #34011

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
stephentoub:disablehttp2test
Mar 24, 2020
Merged

stephentoub merged 1 commit into
dotnet:masterfrom
stephentoub:disablehttp2test

Conversation

@stephentoub

Copy link
Copy Markdown
Member

#33930
This has been failing in the majority of PRs.
cc: @ManickaP, @CourtneyThurston

@davidsh

davidsh commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

@alnikola

@davidsh

davidsh commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

Won't this PR also disable this test on SocketsHttpHandler as well?

@davidsh davidsh added this to the 5.0 milestone Mar 24, 2020
@stephentoub

Copy link
Copy Markdown
Member Author

Won't this PR also disable this test on SocketsHttpHandler as well?

Yes. But we don't currently expose the difference in an easily consumable way to the tests, as far as I can see, and I didn't want to churn the tests just to disable this.

@stephentoub
stephentoub merged commit 7c1ae8d into dotnet:master Mar 24, 2020
@stephentoub
stephentoub deleted the disablehttp2test branch March 24, 2020 17:09
@ManickaP

Copy link
Copy Markdown
Member

I'll look into it.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants