Skip to content

Annotating Native CoreLib library to be AOT friendly#66112

Merged
LakshanF merged 4 commits into
dotnet:mainfrom
LakshanF:AOT_Lib_Annotation
Mar 7, 2022
Merged

Annotating Native CoreLib library to be AOT friendly#66112
LakshanF merged 4 commits into
dotnet:mainfrom
LakshanF:AOT_Lib_Annotation

Conversation

@LakshanF

@LakshanF LakshanF commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Propagated RequiresDynamicCode attribute that are tagged on API's that are dangerous for Native AOT within CoreLib to make the library to be AOT friendly.

Required adding the annotation to the public surface area which in turn required the reference APIs to be annotated (and the CoreCLR and Mono library implementation to be annotated)

@ghost

ghost commented Mar 2, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Mar 2, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Propagated RequiresDynamicCode attribute that are tagged on API's that are dangerous for Native AOT within CoreLib to make the library to be AOT friendly.

Required adding the annotation to the public surface area which in turn required the reference APIs to be annotated (and the CoreCLR and Mono library implementation to be annotated)

Author: LakshanF
Assignees: LakshanF
Labels:

area-System.Reflection, new-api-needs-documentation

Milestone: -

@LakshanF LakshanF requested a review from eerhardt March 2, 2022 21:57
Comment thread src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs Outdated
Comment thread src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs Outdated
Comment thread src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.Core.cs Outdated
…ropServices/ComponentActivator.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

@MichalStrehovsky MichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LakshanF LakshanF merged commit 14c3a15 into dotnet:main Mar 7, 2022
@LakshanF LakshanF deleted the AOT_Lib_Annotation branch March 7, 2022 17:02
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants