Skip to content

measure the perf impact of deduplicating IsCompleted call in GetConsumingEnumerable - #78887

Merged
krwq merged 2 commits into
dotnet:mainfrom
pedrobsaila:69320
Jan 10, 2023
Merged

measure the perf impact of deduplicating IsCompleted call in GetConsumingEnumerable#78887
krwq merged 2 commits into
dotnet:mainfrom
pedrobsaila:69320

Conversation

@pedrobsaila

@pedrobsaila pedrobsaila commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

Fixes #69320

@theodorzoulias sorry I totally forgot about this issue.

I tried your own solution, here is the benchmark code dotnet/performance@main...pedrobsaila:performance:69320 and here are the results (let me know if something should be adjusted in the optimization or benchmark code) :

  • AddRemoveFromSameThreads with optimization :
[2022/11/27 13:08:48][INFO] // * Summary *
[2022/11/27 13:08:48][INFO]
[2022/11/27 13:08:48][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:08:48][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:08:48][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:08:48][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:08:48][INFO]   Job-KRRVNP : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:08:48][INFO]
[2022/11/27 13:08:48][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:08:48][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:08:48][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:08:48][INFO] WarmupCount=-1
[2022/11/27 13:08:48][INFO]
[2022/11/27 13:08:48][INFO] |             Method |    Size |    Mean |    Error |   StdDev |  Median |      Min |     Max |       Gen0 | Allocated |
[2022/11/27 13:08:48][INFO] |------------------- |-------- |--------:|---------:|---------:|--------:|---------:|--------:|-----------:|----------:|
[2022/11/27 13:08:48][INFO] | BlockingCollection | 2000000 | 1.072 s | 0.0812 s | 0.0935 s | 1.069 s | 0.8641 s | 1.248 s | 40000.0000 | 488.29 MB |
  • AddRemoveFromSameThreads with main code :
[2022/11/27 13:37:16][INFO] // * Summary *
[2022/11/27 13:37:16][INFO]
[2022/11/27 13:37:16][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:37:16][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:37:16][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:37:16][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:37:16][INFO]   Job-MUKWDB : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:37:16][INFO]
[2022/11/27 13:37:16][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:37:16][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:37:16][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:37:16][INFO] WarmupCount=-1
[2022/11/27 13:37:16][INFO]
[2022/11/27 13:37:16][INFO] |             Method |    Size |    Mean |    Error |   StdDev |  Median |      Min |     Max |       Gen0 | Allocated |
[2022/11/27 13:37:16][INFO] |------------------- |-------- |--------:|---------:|---------:|--------:|---------:|--------:|-----------:|----------:|
[2022/11/27 13:37:16][INFO] | BlockingCollection | 2000000 | 1.062 s | 0.1468 s | 0.1691 s | 1.089 s | 0.7242 s | 1.329 s | 40000.0000 | 488.28 MB |
  • AddRemoveFromDifferentThreads with optimization :
[2022/11/27 13:28:13][INFO] // * Summary *
[2022/11/27 13:28:13][INFO]
[2022/11/27 13:28:13][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:28:13][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:28:13][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:28:13][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:28:13][INFO]   Job-DSIODT : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:28:13][INFO]
[2022/11/27 13:28:13][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:28:13][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:28:13][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:28:13][INFO] WarmupCount=-1
[2022/11/27 13:28:13][INFO]
[2022/11/27 13:28:13][INFO] |             Method |    Size |     Mean |    Error |   StdDev |   Median |      Min |      Max | Allocated |
[2022/11/27 13:28:13][INFO] |------------------- |-------- |---------:|---------:|---------:|---------:|---------:|---------:|----------:|
[2022/11/27 13:28:13][INFO] | BlockingCollection | 2000000 | 400.1 ms | 58.87 ms | 67.80 ms | 388.2 ms | 292.8 ms | 509.7 ms |  33.22 KB |
  • AddRemoveFromDifferentThreads with main code :
[2022/11/27 13:33:26][INFO] // * Summary *
[2022/11/27 13:33:26][INFO]
[2022/11/27 13:33:26][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:33:26][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:33:26][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:33:26][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:33:26][INFO]   Job-NCVXOG : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:33:26][INFO]
[2022/11/27 13:33:26][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:33:26][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:33:26][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:33:26][INFO] WarmupCount=-1
[2022/11/27 13:33:26][INFO]
[2022/11/27 13:33:26][INFO] |             Method |    Size |     Mean |    Error |   StdDev |   Median |      Min |      Max | Allocated |
[2022/11/27 13:33:26][INFO] |------------------- |-------- |---------:|---------:|---------:|---------:|---------:|---------:|----------:|
[2022/11/27 13:33:26][INFO] | BlockingCollection | 2000000 | 415.7 ms | 27.82 ms | 32.03 ms | 410.6 ms | 354.3 ms | 469.0 ms | 257.97 KB |

@ghost ghost added area-System.Collections community-contribution Indicates that the PR has been added by a community member labels Nov 27, 2022
@ghost

ghost commented Nov 27, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #69320

@theodorzoulias sorry I totally forgot about this issue.

I tried your own solution, here is the benchmark code dotnet/performance@main...pedrobsaila:performance:69320 and here are the results (let me know if something should be adjusted in the optimization or benchmark code) :

  • AddRemoveFromSameThreads with optimization :
[2022/11/27 13:08:48][INFO] // * Summary *
[2022/11/27 13:08:48][INFO]
[2022/11/27 13:08:48][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:08:48][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:08:48][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:08:48][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:08:48][INFO]   Job-KRRVNP : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:08:48][INFO]
[2022/11/27 13:08:48][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:08:48][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:08:48][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:08:48][INFO] WarmupCount=-1
[2022/11/27 13:08:48][INFO]
[2022/11/27 13:08:48][INFO] |             Method |    Size |    Mean |    Error |   StdDev |  Median |      Min |     Max |       Gen0 | Allocated |
[2022/11/27 13:08:48][INFO] |------------------- |-------- |--------:|---------:|---------:|--------:|---------:|--------:|-----------:|----------:|
[2022/11/27 13:08:48][INFO] | BlockingCollection | 2000000 | 1.072 s | 0.0812 s | 0.0935 s | 1.069 s | 0.8641 s | 1.248 s | 40000.0000 | 488.29 MB |
  • AddRemoveFromSameThreads with main code :
[2022/11/27 13:37:16][INFO] // * Summary *
[2022/11/27 13:37:16][INFO]
[2022/11/27 13:37:16][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:37:16][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:37:16][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:37:16][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:37:16][INFO]   Job-MUKWDB : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:37:16][INFO]
[2022/11/27 13:37:16][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:37:16][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:37:16][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:37:16][INFO] WarmupCount=-1
[2022/11/27 13:37:16][INFO]
[2022/11/27 13:37:16][INFO] |             Method |    Size |    Mean |    Error |   StdDev |  Median |      Min |     Max |       Gen0 | Allocated |
[2022/11/27 13:37:16][INFO] |------------------- |-------- |--------:|---------:|---------:|--------:|---------:|--------:|-----------:|----------:|
[2022/11/27 13:37:16][INFO] | BlockingCollection | 2000000 | 1.062 s | 0.1468 s | 0.1691 s | 1.089 s | 0.7242 s | 1.329 s | 40000.0000 | 488.28 MB |
  • AddRemoveFromDifferentThreads with optimization :
[2022/11/27 13:28:13][INFO] // * Summary *
[2022/11/27 13:28:13][INFO]
[2022/11/27 13:28:13][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:28:13][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:28:13][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:28:13][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:28:13][INFO]   Job-DSIODT : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:28:13][INFO]
[2022/11/27 13:28:13][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:28:13][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:28:13][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:28:13][INFO] WarmupCount=-1
[2022/11/27 13:28:13][INFO]
[2022/11/27 13:28:13][INFO] |             Method |    Size |     Mean |    Error |   StdDev |   Median |      Min |      Max | Allocated |
[2022/11/27 13:28:13][INFO] |------------------- |-------- |---------:|---------:|---------:|---------:|---------:|---------:|----------:|
[2022/11/27 13:28:13][INFO] | BlockingCollection | 2000000 | 400.1 ms | 58.87 ms | 67.80 ms | 388.2 ms | 292.8 ms | 509.7 ms |  33.22 KB |
  • AddRemoveFromDifferentThreads with main code :
[2022/11/27 13:33:26][INFO] // * Summary *
[2022/11/27 13:33:26][INFO]
[2022/11/27 13:33:26][INFO] BenchmarkDotNet=v0.13.2.2009-nightly, OS=Windows 11 (10.0.22621.819)
[2022/11/27 13:33:26][INFO] 12th Gen Intel Core i7-12700H, 1 CPU, 20 logical and 14 physical cores
[2022/11/27 13:33:26][INFO] .NET SDK=8.0.100-alpha.1.22575.20
[2022/11/27 13:33:26][INFO]   [Host]     : .NET 8.0.0 (8.0.22.55902), X64 RyuJIT AVX2
[2022/11/27 13:33:26][INFO]   Job-NCVXOG : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
[2022/11/27 13:33:26][INFO]
[2022/11/27 13:33:26][INFO] PowerPlanMode=00000000-0000-0000-0000-000000000000  Toolchain=CoreRun  InvocationCount=1
[2022/11/27 13:33:26][INFO] IterationTime=250.0000 ms  MaxIterationCount=20  MaxWarmupIterationCount=10
[2022/11/27 13:33:26][INFO] MinIterationCount=15  MinWarmupIterationCount=6  UnrollFactor=1
[2022/11/27 13:33:26][INFO] WarmupCount=-1
[2022/11/27 13:33:26][INFO]
[2022/11/27 13:33:26][INFO] |             Method |    Size |     Mean |    Error |   StdDev |   Median |      Min |      Max | Allocated |
[2022/11/27 13:33:26][INFO] |------------------- |-------- |---------:|---------:|---------:|---------:|---------:|---------:|----------:|
[2022/11/27 13:33:26][INFO] | BlockingCollection | 2000000 | 415.7 ms | 27.82 ms | 32.03 ms | 410.6 ms | 354.3 ms | 469.0 ms | 257.97 KB |
Author: pedrobsaila
Assignees: -
Labels:

area-System.Collections
Milestone: -

@build-analysis build-analysis Bot mentioned this pull request Nov 27, 2022
Closed
@pedrobsaila @krwq
simplify the while condition
7479081 
Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
@build-analysis build-analysis Bot mentioned this pull request Jan 10, 2023
Closed
@krwq
krwq merged commit 9d059da into dotnet:main Jan 10, 2023
@pedrobsaila
pedrobsaila deleted the 69320 branch January 10, 2023 14:49
@ghost ghost locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwq krwq krwq approved these changes

Assignees

No one assigned

Labels

area-System.Collections community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can the BlockingCollection<T>.GetConsumingEnumerable iterator be optimized?

3 participants

@pedrobsaila @krwq @eiriktsarpalis