Use VM's copy of daccess.h#97751
Merged
Merged
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsMost of the diffs are caused due to VM's use of Win32 emulator types and AOT's use of standard C types. Since we don't actually build a DAC, the rest of the diffs don't matter. Cc @dotnet/ilc-contrib
|
ghost
assigned
This was referenced Jan 31, 2024
jkotas
reviewed
Feb 1, 2024
jkotas
reviewed
Feb 1, 2024
MichalStrehovsky
force-pushed
the
daccess
branch
from
d78f211 to
00da830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the diffs are caused due to VM's use of Win32 emulator types and AOT's use of standard C types.
Since we don't actually build a DAC, the rest of the diffs don't matter.
Cc @dotnet/ilc-contrib