Skip to content

[QUIC] Updated MsQuic version#99681

Merged
ManickaP merged 3 commits into
dotnet:mainfrom
ManickaP:msquic-version
Mar 14, 2024
Merged

[QUIC] Updated MsQuic version#99681
ManickaP merged 3 commits into
dotnet:mainfrom
ManickaP:msquic-version

Conversation

@ManickaP

Copy link
Copy Markdown
Member

@carlossanlop carlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@ManickaP ManickaP merged commit 09db2b5 into dotnet:main Mar 14, 2024
@ManickaP ManickaP deleted the msquic-version branch March 14, 2024 11:11
@EgorBo

EgorBo commented Mar 14, 2024

Copy link
Copy Markdown
Member

Hm.. local build fails for me with this:

  Restored C:\prj\runtime\src\tasks\MonoTargetsTasks\MonoTargetsTasks.csproj (in 1.52 sec).
C:\prj\runtime\src\libraries\System.Net.Quic\src\System.Net.Quic.csproj : error NU1604: Warning As Error: Project depen
dency Microsoft.Native.Quic.MsQuic.Schannel does not contain an inclusive lower bound. Include a lower bound in the dep
endency version to ensure consistent restore results. [C:\prj\runtime\Build.proj]
  Failed to restore C:\prj\runtime\src\libraries\System.Net.Quic\src\System.Net.Quic.csproj (in 2.83 sec).

@jakobbotsch

Copy link
Copy Markdown
Member

I see the same. Bad interaction between this and #99713?

@CarnaViire

CarnaViire commented Mar 14, 2024

Copy link
Copy Markdown
Member

cc @carlossanlop @ViktorHofer fyi

@ManickaP

Copy link
Copy Markdown
Member Author

I'm working on a fix.

@ManickaP

Copy link
Copy Markdown
Member Author

Fix in #99756

@CarnaViire

Copy link
Copy Markdown
Member

@EgorBo @jakobbotsch fix merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants