Skip to content

[LoongArch64] Avoid using native layout info to calculate register flags for small structs where possible.#99854

Merged
jkotas merged 3 commits into
dotnet:mainfrom
LuckyXu-HF:main-LA64-1
Mar 17, 2024
Merged

[LoongArch64] Avoid using native layout info to calculate register flags for small structs where possible.#99854
jkotas merged 3 commits into
dotnet:mainfrom
LuckyXu-HF:main-LA64-1

Conversation

@LuckyXu-HF

Copy link
Copy Markdown
Contributor

Avoid using native layout info to calculate register flags for small structs where possible for LA64.
This is mentioned in PR #97877

@ghost ghost added the area-VM-coreclr label Mar 16, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Mar 16, 2024
@LuckyXu-HF

LuckyXu-HF commented Mar 16, 2024

Copy link
Copy Markdown
Contributor Author

Hi @tomeksowi @sirntar @jkotas , thank you very much for your reminder!

@shushanhf shushanhf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas

Thanks

Comment thread src/coreclr/vm/methodtable.cpp
…ags for small structs where possible.

* Also merge 'MethodTable::IsLoongArch64OnlyOneField()' and 'MethodTable::IsRiscV64OnlyOneField()' into 'MethodTable::IsOnlyOneField()'.

@tomeksowi tomeksowi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas closed this Mar 16, 2024
@jkotas jkotas reopened this Mar 16, 2024

@clamp03 clamp03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jkotas jkotas merged commit 2351434 into dotnet:main Mar 17, 2024
@LuckyXu-HF LuckyXu-HF deleted the main-LA64-1 branch March 18, 2024 01:01
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants