Warning from RAR with hint path has extra new line

[wli3]

Given a hint path has extra new line. On full msbuild it will have warning:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3246: Resolved file has a bad image, no metada
ta, or is otherwise inaccessible. Illegal characters in path. [C:\work\temp\notNETFrameworkLibrary2\NETFrameworkLibrary.csproj]

• Check if 16.2 has the same warning, the message might be different
• core does not have that error, why?

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Library</OutputType>
    <RestoreAdditionalProjectSources>$(RestoreAdditionalProjectSources);https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json</RestoreAdditionalProjectSources>
    <TargetFramework>net472</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0-preview.2" />
  </ItemGroup>
  <ItemGroup>
    <Reference Include="System.Net.Http">
      <HintPath>
      C:\work\sdk3\artifacts\tmp\Debug\SimpleNamesWi---6143883E\NETFrameworkLibrary\bin\Debug\net462\NETFrameworkLibrary.dll
      </HintPath>
    </Reference>
  </ItemGroup>
</Project>

[wli3]

@nguerrera @rainersigwald @benvillalobos

[wli3]

How to get a 16.2 VS? 16.1 RAR does not have any warning

[rainersigwald]

@wli3 16.2 is live to the public right now, so you should be able to just install from https://visualstudio.microsoft.com/.

[nguerrera]

Hmm I could swear I saw a warning on 16.1. Possibly difference in repro I tried.

[nguerrera]

Hmm, maybe I got the path wrong. Looking at screenshot looks like my attempted repro. I got “not found” maybe it was just pointing to wrong place and not just due to white space. In that case, it seems there was a regression in 16.2

[wli3]

verified. it is a regression in 16.2 . the (same) error message is

"C:\Users\wul\Documents\NETFrameworkLibrary2\NETFrameworkLibrary.csproj" (default target) (1:7) ->
(ResolveAssemblyReferences target) ->
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3246: Resolved file has a bad image, no metadata, or is otherwise inaccessible. Illegal characters in path. [C:\Users\wul\Documents\NETFrameworkLibrary2\NETFrameworkLibrary.csproj]

What's next? Do we want to keep investigate? It is shipped, and seems so far no complain.

[nguerrera]

Given that the original report was on a customer project, I think we should consider fixing the regression in 16.3. We know there are projects in the wild like this.

[rainersigwald]

I agree.

[wli3]

relate to this change? https://github.com/microsoft/msbuild/pull/4414/files

[rainersigwald]

Probably! We should move this to MSBuild and validate.

[wli3]

This issue was moved to dotnet/msbuild#4593