Provide a flag to indicate that Microsoft.NET.Sdk is used - #1242
Merged
Merged
Conversation
rainersigwald
approved these changes
May 23, 2017
Contributor
Author
|
cc @ericstj |
Contributor
Author
|
@MattGertz for approval |
ericstj
approved these changes
May 23, 2017
ericstj
left a comment
ericstj
left a comment
Member
There was a problem hiding this comment.
LGTM, as discussed there may be some other properties needed as well. This is sufficient for the places where we are trying to sequence our targets with yours.
Contributor
Author
|
@dotnet-bot test Windows_NT_FullFramework Debug please We finally have readable output for the full framework flakiness and it seems desktop msbuild is just crashing. I will be investigating that separately, but in the meantime, we're still stuck retesting. :( |
AArnott
approved these changes
May 24, 2017
dsplaisted
approved these changes
May 24, 2017
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…127.7 (dotnet#1242) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20077.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
Partner and ecosystem features need to be able to adjust themselves based on whether or not the project they're working with uses Microsoft.NET.Sdk. This has been identified as blocking corefx for preview2.
Bugs this fixes:
#534
Workarounds, if any
None. There were some unsupported things you could sniff, but all of them were defined too late for use in corefx's scenario. This gives an official, supported property that is set as early as possible.
Risk
Low.
Performance impact
None.
Is this a regression from a previous update?
No
Root cause analysis:
N/A
How was the bug found?
N/A
@MattGertz for approval