Skip to content

Fix dogfood script - #1820

Merged
nguerrera merged 1 commit into
dotnet:masterfrom
nguerrera:fix-dogfood
Dec 18, 2017
Merged

Fix dogfood script#1820
nguerrera merged 1 commit into
dotnet:masterfrom
nguerrera:fix-dogfood

Conversation

@nguerrera

@nguerrera nguerrera commented Dec 14, 2017

Copy link
Copy Markdown
Contributor

There were two issues:

  1. The CustomAfterMicrosoftCommonTargets is no longer needed and causes duplicate import warning/errors.
  2. MicrosoftNETBuildExtensionsTargets was not being set to the correct file (it should not be the variant with -ver).

@nguerrera
nguerrera merged commit a7f6503 into dotnet:master Dec 18, 2017
@nguerrera
nguerrera deleted the fix-dogfood branch December 18, 2017 22:42
@nguerrera nguerrera mentioned this pull request Feb 9, 2018
Merged
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 9, 2018
@nguerrera @dsplaisted
Cherry-pick fix for -dogfood option from PR dotnet#1820
00325a3
@nguerrera
nguerrera restored the fix-dogfood branch February 28, 2018 21:11
JL03-Yue pushed a commit that referenced this pull request Mar 19, 2024
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
18e261a 
…424.3 (#1820)

[main] Update dependencies from dotnet/arcade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannergooding tannergooding tannergooding approved these changes
@dsplaisted dsplaisted Awaiting requested review from dsplaisted
+1 more reviewer
@livarcocc livarcocc livarcocc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nguerrera @livarcocc @tannergooding