Skip to content

Update implicit NETStandard.Library package version, and re-enable test #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsplaisted merged 2 commits into from
Feb 27, 2018
Merged

Update implicit NETStandard.Library package version, and re-enable test #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f168829
Re-enable test for error targeting .NET Standard 2.1
dsplaisted Feb 23, 2018
8b560b8
Update to version 2.0.2 of NETStandard.Library package
dsplaisted Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ Copyright (c) .NET Foundation. All rights reserved.
produced, so we will roll forward to the latest version. -->
<NETStandardImplicitPackageVersion Condition="'$(NETStandardImplicitPackageVersion)' =='' And '$(_TargetFrameworkVersionWithoutV)' &lt; '2.0'">1.6.1</NETStandardImplicitPackageVersion>

<!-- Default to use the latest stable release. Currently this is the same as the previous clause, but when we have a stable 2.0 package this should change. -->
<NETStandardImplicitPackageVersion Condition="'$(NETStandardImplicitPackageVersion)' ==''">2.0.1</NETStandardImplicitPackageVersion>
<!-- Default to use the latest stable release. -->
<NETStandardImplicitPackageVersion Condition="'$(NETStandardImplicitPackageVersion)' ==''">2.0.2</NETStandardImplicitPackageVersion>
</PropertyGroup>

<!--
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ private void TestInvalidTargetFramework(string testName, string targetFramework,

[Theory]
[InlineData("netcoreapp2.2")]
[InlineData("netstandard2.3")]
[InlineData("netstandard2.1")]
public void It_fails_to_build_if_targeting_a_higher_framework_than_is_supported(string targetFramework)
{
var testProject = new TestProject()
Expand Down