Skip to content

Execute the unit tests during the build. - #29

Merged
eerhardt merged 1 commit into
dotnet:masterfrom
eerhardt:ExecuteUnitTests
Aug 9, 2016
Merged

eerhardt merged 1 commit into
dotnet:masterfrom
eerhardt:ExecuteUnitTests

Conversation

@eerhardt

@eerhardt eerhardt commented Aug 8, 2016

Copy link
Copy Markdown
Member

This change executes our unit tests during the build.

Basically the approach is that we have a src\Dependencies\xUnit.net project that ensures the xunit assemblies are placed into the tests directory. The tests are executed by the build.proj, just like it is in dotnet\roslyn-project-system's build.proj.

I had to copy a little bit of infrastructure from @333fred's PR: #7

@natidea @333fred @davkean @livarcocc @piotrpMSFT @brthor

@natidea

natidea commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

👍
Confirmed I can run/fail tests from command line. However I still cannot run from Visual Studio Test Explorer.

@eerhardt

eerhardt commented Aug 9, 2016

Copy link
Copy Markdown
Member Author

Yes. It is going to take more work to get VS to execute the tests. But this is a start. At least they will run in CI.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove VB and C++.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@333fred

333fred commented Aug 9, 2016

Copy link
Copy Markdown
Member

👍 modulo comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@333fred Do we need anything here except CSharp?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unless we plan on shipping C++/VB code.

@eerhardt
eerhardt merged commit d213940 into dotnet:master Aug 9, 2016
@eerhardt
eerhardt deleted the ExecuteUnitTests branch August 9, 2016 20:21
nguerrera pushed a commit that referenced this pull request Oct 10, 2016
Execute the unit tests during the build.
mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
Removing the project.json from NetCore library
GangWang01 pushed a commit to GangWang01/sdk that referenced this pull request Mar 20, 2023
Add test for UncompressedDigest

Fix dotnet#29
springmin added a commit to springmin/sdk-ohos that referenced this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants