Skip to content

Use netstandard1.3 in our tasks library. - #5

Merged
eerhardt merged 2 commits into
dotnet:masterfrom
eerhardt:UseNetstandard1.3
Aug 3, 2016
Merged

Use netstandard1.3 in our tasks library.#5
eerhardt merged 2 commits into
dotnet:masterfrom
eerhardt:UseNetstandard1.3

Conversation

@eerhardt

@eerhardt eerhardt commented Aug 2, 2016

Copy link
Copy Markdown
Member

I also added the current "Sdk" .props and .targets files from the dotnet/cli repo. We can modify these as we go. Our "Tasks" library will be the first test for these .props and .targets files.

@eerhardt

eerhardt commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

/cc @natidea @davkean @333fred

brthor
brthor reviewed Aug 2, 2016
View reviewed changes
Comment thread src/Tasks/Microsoft.DotNet.Core.Build.Tasks/Microsoft.DotNet.Core.Build.Tasks.csproj
<TargetFrameworkVersion>v1.3</TargetFrameworkVersion>
</PropertyGroup>
<ItemGroup>
<None Include="Microsoft.DotNet.Core.Sdk.targets" />

@brthor brthor Aug 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be copied to output?

@eerhardt eerhardt Aug 2, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. It needs to get packaged into the .nupkg (which is my next step). That will get figured out then.

@brthor brthor Aug 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sounds good.

@333fred

333fred commented Aug 2, 2016

Copy link
Copy Markdown
Member

build.cmd fails with this patch, lots of missing assembly and using references.

@eerhardt

eerhardt commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

build.cmd fails with this patch, lots of missing assembly and using references.

I assume build.cmd will need to call restore before build. Can you try restoring in VS on your machine and then call build.cmd?

@eerhardt

eerhardt commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

I can work on getting an LKG version of the CLI installed during build.cmd, which will then be able to restore. And we can use "dotnet build3", which will build the solution, instead of relying on msbuild being installed on the box.

@333fred

333fred commented Aug 2, 2016

Copy link
Copy Markdown
Member

Yeah, restore fixed it. For that version of .NET, would we have to include it in the repo, or are we going to have to configure Jenkins slaves and microbuild instances with those binaries?

@eerhardt

eerhardt commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

would we have to include it in the repo, or are we going to have to configure Jenkins slaves and microbuild instances with those binaries?

It will be downloaded "on the fly"

@eerhardt

eerhardt commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

@333fred - how about now? does it build cleanly on your box with my latest change?

@eerhardt
eerhardt force-pushed the UseNetstandard1.3 branch from b13e7df to ad3834f Compare August 2, 2016 22:54
@333fred

333fred commented Aug 2, 2016

Copy link
Copy Markdown
Member

@eerhardt yep, clean build works just fine now, restoring all packages.

brthor
brthor reviewed Aug 2, 2016
View reviewed changes
Comment thread build.ps1 Outdated

@brthor brthor Aug 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the space here throw off the arg parsing when passing it through to msbuild?

@eerhardt eerhardt Aug 2, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to on my box. It failed when this wasn't supplied. It passes now.

@brthor brthor Aug 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with PS quoting defaults as bash, thanks for the clarification.

@natidea

natidea commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

:shipit:

@eerhardt
eerhardt force-pushed the UseNetstandard1.3 branch from ad3834f to 8c5a153 Compare August 3, 2016 02:33
@eerhardt
eerhardt merged commit e911e26 into dotnet:master Aug 3, 2016
@eerhardt
eerhardt deleted the UseNetstandard1.3 branch August 3, 2016 02:34
nguerrera pushed a commit that referenced this pull request Oct 10, 2016
@eerhardt
Merge pull request #5 from eerhardt/UseNetstandard1.3
a4077d8 
Use netstandard1.3 in our tasks library.
This was referenced May 1, 2019
Merged
Merged
mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
@vijayrkn
Merge pull request dotnet#5 from aspnet/MsBuildVersion
876102b 
Fixing the MsBuild version in the tasks assembly
@rainersigwald rainersigwald mentioned this pull request Nov 29, 2022
Merged
dsplaisted added a commit to dsplaisted/sdk that referenced this pull request Mar 5, 2026
@dsplaisted
Apply Round 2 code review feedback
ec12851 
Changes include:
- Rename 'managed installations' to 'tracked installations' (dotnet#10)
- Fix '.metadata' -> 'metadata' folder name (dotnet#18)
- Include component type in error/warning messages (dotnet#11)
- Remove component spec from runtime update (dotnet#12)
- Remove GetInstallations wrapper (dotnet#6)
- ScopedMutex throws TimeoutException on failure (dotnet#22)
- Make InstallResult.Install non-nullable (dotnet#17)
- Remove ComponentFilesExist shortcut (dotnet#19)
- Wire up InstallSource enum (dotnet#21)
- ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1)
- Show global.json path in list output (dotnet#15)
- Add doc comments to ListData types (dotnet#7)
- Move SourceOption to CommonOptions, remove alias fields (dotnet#9)
- Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14)
- Root 'dotnetup update' updates all components (dotnet#16)
- GlobalJsonChannelResolver: support rollForward policy (dotnet#13)
- Error when installing to unmanaged dotnet root (dotnet#20)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsplaisted added a commit to dsplaisted/sdk that referenced this pull request Mar 6, 2026
@dsplaisted
Apply Round 3 code review feedback
c24110b 
Changes include:
- UpdateWorkflow.Execute returns non-zero exit code on failure (#1)
- InfoCommand JSON output includes InstallSpecs (dotnet#2)
- Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3)
- Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3)
- Fix ResolveEntryDestPath to use normalized entry name (dotnet#4)
- Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5)
- Fix test: LTS assertion checks Major instead of Minor (dotnet#6)
- Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7)
- Make CommonOptions fields static readonly (dotnet#9)
- Remove unused --no-progress from uninstall parsers (dotnet#10)
- GarbageCollector catches Exception instead of just IOException (dotnet#11)
- Capitalize 'SDK' in SdkCommandParser description (dotnet#12)
- Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13)
- Fix STS test error message to say 'major' not 'minor' (dotnet#14)
- Make DotnetupUtilities.ExeSuffix readonly (dotnet#16)
- Fix FormatBytes to use floating-point with one decimal (dotnet#17)
- Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18)
- Make UpdateChannel.Name immutable (dotnet#19)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mmitche added a commit that referenced this pull request Mar 13, 2026
@mmitche
Fix CI flakiness: 5 root causes addressing 48% failure rate
b5aaba8 
Root causes fixed:
1. MSB4216 task host failures: Export DOTNET_HOST_PATH in Helix test scripts
   so MSBuild task host processes resolve the correct runtime.

2. dotnet-watch Aspire test hangs: Cap per-operation timeout at 5 minutes
   (was inheriting full 2-hour Helix timeout), close stdin before killing
   process tree, add 30s exit timeout in DisposeAsync, bound DCP timeouts
   to 300s, fix semaphore deadlock in AspireServiceFactory.DisposeAsync.

3. GZipCompress file lock race: Add retry with exponential backoff for
   IOException in BlazorWasm GZipCompress parallel compression loop.

4. NuGet source removal noise: Suppress errors from dotnet nuget remove
   commands in Helix scripts that fail when sources don't exist.

5. Hot reload file lock race: Add retry with exponential backoff in
   CompilationHandler.UpdateFileContentAsync for IOException when
   source files are transiently locked by relaunching processes.

Validation: 8 consecutive passing builds (18/18 jobs each) before
adding fix #5 for a newly-added test (RelaunchOnCrash).

Files changed:
- build/RunTestsOnHelix.sh: DOTNET_HOST_PATH export + NuGet error suppression
- build/RunTestsOnHelix.cmd: DOTNET_HOST_PATH export + NuGet error suppression
- test/Microsoft.DotNet.HotReload.Test.Utilities/AwaitableProcess.cs: 5-min timeout cap
- test/Microsoft.DotNet.HotReload.Test.Utilities/WatchableApp.cs: DCP timeout bounds
- src/Dotnet.Watch/Watch/Aspire/AspireServiceFactory.cs: Semaphore deadlock fix
- src/BlazorWasmSdk/Tasks/GZipCompress.cs: File lock retry logic
- src/Dotnet.Watch/Watch/HotReload/CompilationHandler.cs: File lock retry logic
- test/TestAssets/Directory.Build.targets: runtimeconfig.json for test tool packages
mmitche added a commit that referenced this pull request Mar 13, 2026
@mmitche
Fix CI flakiness: 5 root causes addressing 48% failure rate
f547f2a 
Root causes fixed:
1. MSB4216 task host failures: Export DOTNET_HOST_PATH in Helix test scripts
   so MSBuild task host processes resolve the correct runtime.

2. dotnet-watch Aspire test hangs: Cap per-operation timeout at 5 minutes
   (was inheriting full 2-hour Helix timeout), close stdin before killing
   process tree, add 30s exit timeout in DisposeAsync, bound DCP timeouts
   to 300s, fix semaphore deadlock in AspireServiceFactory.DisposeAsync.

3. GZipCompress file lock race: Add retry with exponential backoff for
   IOException in BlazorWasm GZipCompress parallel compression loop.

4. NuGet source removal noise: Suppress errors from dotnet nuget remove
   commands in Helix scripts that fail when sources don't exist.

5. Hot reload file lock race: Add retry with exponential backoff in
   CompilationHandler.UpdateFileContentAsync for IOException when
   source files are transiently locked by relaunching processes.

Validation: 8 consecutive passing builds (18/18 jobs each) before
adding fix #5 for a newly-added test (RelaunchOnCrash).

Files changed:
- build/RunTestsOnHelix.sh: DOTNET_HOST_PATH export + NuGet error suppression
- build/RunTestsOnHelix.cmd: DOTNET_HOST_PATH export + NuGet error suppression
- test/Microsoft.DotNet.HotReload.Test.Utilities/AwaitableProcess.cs: 5-min timeout cap
- test/Microsoft.DotNet.HotReload.Test.Utilities/WatchableApp.cs: DCP timeout bounds
- src/Dotnet.Watch/Watch/Aspire/AspireServiceFactory.cs: Semaphore deadlock fix
- src/BlazorWasmSdk/Tasks/GZipCompress.cs: File lock retry logic
- src/Dotnet.Watch/Watch/HotReload/CompilationHandler.cs: File lock retry logic
- test/TestAssets/Directory.Build.targets: runtimeconfig.json for test tool packages
mmitche added a commit that referenced this pull request Mar 14, 2026
@mmitche
Fix CI flakiness: 5 root causes addressing 48% failure rate
0d45dcc 
Root causes fixed:
1. MSB4216 task host failures: Export DOTNET_HOST_PATH in Helix test scripts
   so MSBuild task host processes resolve the correct runtime.

2. dotnet-watch Aspire test hangs: Cap per-operation timeout at 5 minutes
   (was inheriting full 2-hour Helix timeout), close stdin before killing
   process tree, add 30s exit timeout in DisposeAsync, bound DCP timeouts
   to 300s, fix semaphore deadlock in AspireServiceFactory.DisposeAsync.

3. GZipCompress file lock race: Add retry with exponential backoff for
   IOException in BlazorWasm GZipCompress parallel compression loop.

4. NuGet source removal noise: Suppress errors from dotnet nuget remove
   commands in Helix scripts that fail when sources don't exist.

5. Hot reload file lock race: Add retry with exponential backoff in
   CompilationHandler.UpdateFileContentAsync for IOException when
   source files are transiently locked by relaunching processes.

Validation: 8 consecutive passing builds (18/18 jobs each) before
adding fix #5 for a newly-added test (RelaunchOnCrash).

Files changed:
- build/RunTestsOnHelix.sh: DOTNET_HOST_PATH export + NuGet error suppression
- build/RunTestsOnHelix.cmd: DOTNET_HOST_PATH export + NuGet error suppression
- test/Microsoft.DotNet.HotReload.Test.Utilities/AwaitableProcess.cs: 5-min timeout cap
- test/Microsoft.DotNet.HotReload.Test.Utilities/WatchableApp.cs: DCP timeout bounds
- src/Dotnet.Watch/Watch/Aspire/AspireServiceFactory.cs: Semaphore deadlock fix
- src/BlazorWasmSdk/Tasks/GZipCompress.cs: File lock retry logic
- src/Dotnet.Watch/Watch/HotReload/CompilationHandler.cs: File lock retry logic
- test/TestAssets/Directory.Build.targets: runtimeconfig.json for test tool packages
mmitche added a commit that referenced this pull request Mar 18, 2026
@mmitche
Trigger CI build #5 - streak reset (dotnet-watch flaky test)
672d0ec 
Build #4 failed due to pre-existing flaky dotnet-watch test:
ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0)
This is not related to our PR changes. Restarting streak count.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eerhardt @333fred @natidea @brthor