Skip to content

Skip flaky/broken tests on release/10.0.4xx #54277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcpopMSFT wants to merge 1 commit into from
Closed

Skip flaky/broken tests on release/10.0.4xx #54277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions src/BlazorWasmSdk/Tasks/GZipCompress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,30 @@ public override bool Execute()
Log.LogMessage(MessageImportance.Low, "Compressing '{0}' because file is newer than '{1}'.", inputFullPath, outputRelativePath);
}

try
const int maxRetries = 3;
for (int retry = 0; retry <= maxRetries; retry++)
Comment thread
marcpopMSFT marked this conversation as resolved.
{
using var sourceStream = File.OpenRead(file.ItemSpec);
using var fileStream = File.Create(outputRelativePath);
using var stream = new GZipStream(fileStream, CompressionLevel.Optimal);
try
{
using var sourceStream = File.OpenRead(file.ItemSpec);
using var fileStream = File.Create(outputRelativePath);
using var stream = new GZipStream(fileStream, CompressionLevel.Optimal);

sourceStream.CopyTo(stream);
}
catch (Exception e)
{
Log.LogErrorFromException(e);
return;
sourceStream.CopyTo(stream);
break;
}
catch (IOException) when (retry < maxRetries)
{
Log.LogMessage(MessageImportance.High,
"Unable to access file '{0}' during GZip compression. Retrying ({1}/{2})...",
outputRelativePath, retry + 1, maxRetries);
Thread.Sleep(100 * (retry + 1));
}
catch (Exception e)
{
Log.LogErrorFromException(e);
return;
}
}
});

Expand Down
12 changes: 11 additions & 1 deletion test/dotnet-new.IntegrationTests/WebProjectsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public WebProjectsTests(WebProjectsFixture fixture, ITestOutputHelper log) : bas
[InlineData("api_cs-80", "webapi", "-f", "net8.0")]
[InlineData("emptyweb_cs-90", "web", "-f", "net9.0")]
[InlineData("mvc_cs-90", "mvc", "-f", "net9.0")]
[InlineData("mvc_fs-90", "mvc", "-lang", "F#", "-f", "net9.0")]
// mvc_fs-90 moved to separate skipped test - see https://github.com/dotnet/sdk/issues/54267
[InlineData("api_cs-90", "webapi", "-f", "net9.0")]
public void AllWebProjectsRestoreAndBuild(string testName, params string[] args)
{
Expand Down Expand Up @@ -70,6 +70,16 @@ public void AllWebProjectsRestoreAndBuild(string testName, params string[] args)
Directory.Delete(workingDir, true);
}

// F# MVC targeting net9.0 fails restore because Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation
// at the implicit version may not be available on CI feeds yet.
#pragma warning disable xUnit1004 // Test methods should not be skipped
[Fact(Skip = "https://github.com/dotnet/sdk/issues/40073")]
public void AllWebProjectsRestoreAndBuild_FSharpMvc90()
#pragma warning restore xUnit1004
{
AllWebProjectsRestoreAndBuild("mvc_fs-90", "mvc", "-lang", "F#", "-f", "net9.0");
}

[Fact]
public Task CanShowHelp_WebAPI()
{
Expand Down
Loading