Remove unused client name. - #54629
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unused “client name” concept from dotnet watch hot reload client wiring by switching from ImmutableArray<(HotReloadClient client, string name)> to ImmutableArray<HotReloadClient>. This simplifies app model implementations and the HotReloadClients coordinator, reducing tuple deconstruction and eliminating unused string values.
Changes:
- Replace managed-client creation APIs to return
ImmutableArray<HotReloadClient>instead of(client, name)tuples. - Update
HotReloadClientsto operate on plain clients (iteration, list patterns, LINQ projections), and add aClientsaccessor. - Update all app models that construct managed clients to use the new return type.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Dotnet.Watch/Watch/AppModels/WebServerAppModel.cs | Updates managed client creation to return plain HotReloadClient instances. |
| src/Dotnet.Watch/Watch/AppModels/WebApplicationAppModel.cs | Changes the abstract factory signature and corresponding call site to use ImmutableArray<HotReloadClient>. |
| src/Dotnet.Watch/Watch/AppModels/MobileAppModel.cs | Updates local client collection type and initialization to the new client-only shape. |
| src/Dotnet.Watch/Watch/AppModels/DefaultAppModel.cs | Updates HotReloadClients construction to pass ImmutableArray<HotReloadClient> collection expressions. |
| src/Dotnet.Watch/Watch/AppModels/BlazorWebAssemblyHostedAppModel.cs | Removes unused client-name labels (“client”/“host”) and returns only clients. |
| src/Dotnet.Watch/Watch/AppModels/BlazorWebAssemblyAppModel.cs | Removes unused empty-name tuple and returns only the WebAssembly client. |
| src/Dotnet.Watch/HotReloadClient/HotReloadClients.cs | Refactors internal logic from tuple-based clients to plain clients; adds Clients property. |
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.