Fix GivenThatWeWantToUseFrameworkRoslyn tests - #54829
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GivenThatWeWantToUseFrameworkRoslyn restore/build tests to avoid relying on MSBuild “tearing” simulation and to better align with the intended BuildWithNetFrameworkHostedCompiler opt-in behavior while addressing failures on release/10.0.3xx (NuGet 7.6 behavior differences).
Changes:
- Removes the “MSBuild is torn” compiler-toolset download test and stops forcing
_IsDisjointMSBuildVersion. - Switches tests to explicitly opt into the framework-hosted compiler via
BuildWithNetFrameworkHostedCompiler=true. - Simplifies MSBuild invocations by removing
DOTNET_HOST_PATH/DOTNET_EXPERIMENTAL_HOST_PATHproperty overrides.
nagilson
approved these changes
Jun 18, 2026
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54828.