Skip to content

Disable failing Mark-of-the-Web test and fix parallel test failures #54945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsplaisted merged 4 commits into from
Jun 24, 2026
Merged

Disable failing Mark-of-the-Web test and fix parallel test failures #54945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8489e73
Disable MOTW test on IE-less Windows images (dotnet/sdk#54951)
dsplaisted Jun 23, 2026
ee91120
Serialize DependencyProviderTests to fix registry-key race under Meth…
dsplaisted Jun 23, 2026
8fba220
Fix ILLink_TrimMode_new_options binlog collision under parallel DataRows
dsplaisted Jun 24, 2026
eb8fedf
Merge branch 'main' into 10124-versionless-packagereference
dsplaisted Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/Microsoft.DotNet.Cli.Utils.Tests/DangerousFileDetectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public DangerousFileDetectorTests()
#endif
[TestMethod]
[OSCondition(OperatingSystems.Windows)]
[Ignore("https://github.com/dotnet/sdk/issues/54951")]
public void ItShouldDetectFileWithMarkOfTheWeb()
{
var testFile = Path.Combine(TestAssetsManager.CreateTestDirectory().Path, Path.GetRandomFileName());
Expand Down
5 changes: 5 additions & 0 deletions test/Microsoft.DotNet.Cli.Utils.Tests/DependencyProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
namespace Microsoft.DotNet.Cli.Utils.Tests
{
#pragma warning disable CA1416
// These tests share a single hardcoded registry key (.NET_SDK_TEST_PROVIDER_KEY) and mutate it
// (create/add/remove/delete), so they must not run concurrently. xUnit ran methods within a class
// serially; under MSTest MethodLevel parallelism (see https://github.com/dotnet/sdk/pull/54766)
// they race, producing intermittent "expected 1, actual 2 dependents" and missing-subkey failures.
[DoNotParallelize]
[TestClass]
public class DependencyProviderTests
{
Expand Down
3 changes: 3 additions & 0 deletions test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink1b.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ public void ILLink_TrimMode_new_options(string targetFramework, string trimMode)
.WithProjectChanges(project => SetGlobalTrimMode(project, trimMode));

var publishCommand = new PublishCommand(testAsset);
// Run from the (per-DataRow unique) project directory so the "-bl" binary log is written there
// instead of the shared current directory, where parallel DataRows would collide on msbuild.binlog.
publishCommand.WorkingDirectory = Path.Combine(testAsset.TestRoot, projectName);
publishCommand.Execute($"/p:RuntimeIdentifier={rid}", "-bl").Should().Pass();

var publishDirectory = publishCommand.GetOutputDirectory(targetFramework: targetFramework, runtimeIdentifier: rid).FullName;
Expand Down
Loading