Use Combinatorial.MSTest for boolean DataRow tests in TemplateEngine unit tests - #55014
Closed
Evangelink wants to merge 1 commit into
Closed
Evangelink wants to merge 1 commit into
Evangelink wants to merge 1 commit into
Conversation
…unit tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label. |
Evangelink
had a problem deploying
to
copilot-pat-pool
August 26, 2026 12:59 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces full boolean cartesian-product
[DataRow]sets with[CombinatorialData](from theCombinatorial.MSTestpackage) in the TemplateEngine test subprojects.What changed
Microsoft.TemplateEngine.Core.UnitTests– 2 methods converted:VerifyWhitespaceHandlerConsumeWholeLine(8 DataRows → CombinatorialData)VerifyWhitespaceHandlerTrim(4 DataRows → CombinatorialData)Microsoft.TemplateEngine.TemplateLocalizer.Core.UnitTests– 2 methods converted:UnchangedFileShouldntBeOverwritten(2 DataRows → CombinatorialData)BomPreambleIsPreserved(2 DataRows → CombinatorialData)Both
.csprojfiles receive a newItemGroupwith:Behaviour
Identical test cases are executed —
[CombinatorialData]generates the same full boolean product as the explicit[DataRow]list, just without the boilerplate.Series
This is part of a per-project series replacing redundant boolean
[DataRow]combinations with[CombinatorialData]across the SDK test suite.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com