Skip to content

Use Combinatorial.MSTest for boolean DataRow tests in TemplateEngine unit tests - #55014

Closed
Evangelink wants to merge 1 commit into
dotnet:mainfrom
Evangelink:dev/amauryleve/combinatorial-templateengine-tests
Closed

Evangelink wants to merge 1 commit into
dotnet:mainfrom
Evangelink:dev/amauryleve/combinatorial-templateengine-tests

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Replaces full boolean cartesian-product [DataRow] sets with [CombinatorialData] (from the Combinatorial.MSTest package) in the TemplateEngine test subprojects.

What changed

  • Microsoft.TemplateEngine.Core.UnitTests – 2 methods converted:
    • VerifyWhitespaceHandlerConsumeWholeLine (8 DataRows → CombinatorialData)
    • VerifyWhitespaceHandlerTrim (4 DataRows → CombinatorialData)
  • Microsoft.TemplateEngine.TemplateLocalizer.Core.UnitTests – 2 methods converted:
    • UnchangedFileShouldntBeOverwritten (2 DataRows → CombinatorialData)
    • BomPreambleIsPreserved (2 DataRows → CombinatorialData)

Both .csproj files receive a new ItemGroup with:

<PackageReference Include="Combinatorial.MSTest" />
<Using Include="Combinatorial.MSTest" />

Behaviour

Identical test cases are executed — [CombinatorialData] generates the same full boolean product as the explicit [DataRow] list, just without the boilerplate.

Series

This is part of a per-project series replacing redundant boolean [DataRow] combinations with [CombinatorialData] across the SDK test suite.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

…unit tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label.

This branch had an error being deployed

1 failed deployment
copilot-pat-pool — 861b88bf Deployed Aug 26, 2026 by Evangelink via pre_activation #1015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants