Skip to content

Add new NuGet cert hash - #56242

Merged
mmitche merged 1 commit into
mainfrom
mmitche-patch-1
Sep 11, 2026
Merged

mmitche merged 1 commit into
mainfrom
mmitche-patch-1

Conversation

@mmitche

@mmitche mmitche commented Sep 10, 2026

Copy link
Copy Markdown
Member

The new certificate will be live soon. Add the new cert hash.

The new certificate will be live soon. Add the new cert hash.
Copilot AI lite review requested due to automatic review settings September 10, 2026 22:21
@mmitche
mmitche requested a review from a team as a code owner September 10, 2026 22:21
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused certificate allowlist update has no unresolved review issues.

Pull request overview

Adds the upcoming Microsoft NuGet signing certificate SHA-256 thumbprint to first-party package verification.

Changes:

  • Adds the new certificate hash to the trusted allowlist.
File summaries
File Description
src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs Adds the new trusted certificate thumbprint.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

@mmitche
mmitche merged commit 7487ae3 into main Sep 11, 2026
25 checks passed
@mmitche
mmitche deleted the mmitche-patch-1 branch September 11, 2026 13:49
@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/11.0.1xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx (link to workflow run)

@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/10.0.1xx

@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/10.0.4xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0.1xx (link to workflow run)

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0.4xx (link to workflow run)

@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/9.0.1xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.1xx (link to workflow run)

@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/8.0.1xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0.1xx (link to workflow run)

@github-actions

Copy link
Copy Markdown
Contributor

@mmitche backporting to release/9.0.1xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git cherry-pick 7487ae326d70d04b9f03042c49e8a82bd25e3077

Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: could not apply 7487ae326d... Add new NuGet cert hash (#56242)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"


$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Add new NuGet cert hash
Using index info to reconstruct a base tree...
M	src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add new NuGet cert hash
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

@github-actions

Copy link
Copy Markdown
Contributor

@mmitche backporting to release/8.0.1xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git cherry-pick 7487ae326d70d04b9f03042c49e8a82bd25e3077

Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: could not apply 7487ae326d... Add new NuGet cert hash (#56242)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"


$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Add new NuGet cert hash
Using index info to reconstruct a base tree...
M	src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add new NuGet cert hash
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/9.0.3xx

@mmitche

mmitche commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/backport to release/8.0.4xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.3xx (link to workflow run)

@github-actions

Copy link
Copy Markdown
Contributor

@mmitche backporting to release/9.0.3xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git cherry-pick 7487ae326d70d04b9f03042c49e8a82bd25e3077

Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: could not apply 7487ae326d... Add new NuGet cert hash (#56242)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"


$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Add new NuGet cert hash
Using index info to reconstruct a base tree...
M	src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add new NuGet cert hash
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0.4xx (link to workflow run)

@github-actions

Copy link
Copy Markdown
Contributor

@mmitche backporting to release/8.0.4xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git cherry-pick 7487ae326d70d04b9f03042c49e8a82bd25e3077

Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: could not apply 7487ae326d... Add new NuGet cert hash (#56242)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"


$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Add new NuGet cert hash
Using index info to reconstruct a base tree...
M	src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/NugetPackageDownloader/FirstPartyNuGetPackageSigningVerifier.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add new NuGet cert hash
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

This branch had an error being deployed

1 failed deployment
copilot-pat-pool — 94131db1 Deployed Sep 11, 2026 by mmitche via pre_activation #4392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants